refactor: remove pytest parametrize support, keep fixture features only#12
Merged
Conversation
Remove all modules related to pytest.mark.parametrize and pytest cache: - Delete call_spec.lua, nodeids.lua, marks.lua, strings.lua, tables.lua - Delete jump/param.lua and its tests - Remove Pytrize, PytrizeClear, PytrizeJump commands - Remove .pytest_cache and pytest.ini from root markers - Remove get_nodeids_path from paths.lua - Update rename test to use .git instead of .pytest_cache as root marker - Rewrite README to focus on fixture features only
sigfriedCub1990
force-pushed
the
feat/fzf-lua-integration
branch
from
a8507ad to
3a47715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all pytest parametrize and cache-related functionality, keeping only the fixture features (jump, rename, usages).
Changes
Deleted modules
call_spec.lua— parametrize call parsingnodeids.lua— pytest cache nodeids readermarks.lua— virtual text extmarks for parametrizestrings.lua—split_oncehelper (only used by nodeids)tables.lua—reverse/list_maphelpers (only used by parametrize code)jump/param.lua— jump to parametrize declarationDeleted tests
call_spec_spec.lua,nodeids_spec.lua,strings_spec.lua,tables_spec.luaModified
api.lua— removedclear(),set(),jump()jump/init.lua— removed param importinit.lua— removedPytrize,PytrizeClear,PytrizeJumpcommandspaths.lua— removed.pytest_cache/pytest.inifrom root markers, removedget_nodeids_path()rename_spec.lua— use.gitinstead of.pytest_cacheas root marker in testREADME.md— rewritten to focus on fixture features onlyNet: -890 lines, +37 lines. All tests pass.