Support for multiple assignees on issue closing/re-opening#1191
Merged
sigmavirus24 merged 2 commits intosigmavirus24:mainfrom Jun 7, 2025
8R0WNI3:main
Merged
Support for multiple assignees on issue closing/re-opening#1191sigmavirus24 merged 2 commits intosigmavirus24:mainfrom 8R0WNI3:main
sigmavirus24 merged 2 commits intosigmavirus24:mainfrom
8R0WNI3:main
Conversation
Contributor
Author
|
Hi @sigmavirus24, is there still anything left for me to do before this pull request can be reviewed/merged? :-) |
Owner
|
Could you add a note to the next release's release notes? |
Resolves #1128 I updated `issue.py` to consider `assignees` also on issue closing as well as re-opening. This prevents extra-assignees from being unassigned if an issue is closed and allows re-opening the issue with the same set of assignees. I adjusted existing tests to also examine `assignees` property for said operations.
Contributor
Author
|
Thank you for the suggestion, I just added initial release notes for the |
sigmavirus24
reviewed
Jun 6, 2025
Owner
sigmavirus24
left a comment
sigmavirus24
left a comment
There was a problem hiding this comment.
Did you verify locally that the change log renders correctly with your addition? I think I eye-balled the wrong one but it leaves me little confidence the rest of it renders appropriately
sigmavirus24
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1128
I updated
issue.pyto considerassigneesalso on issue closing as well as re-opening. This prevents extra-assignees from being unassigned if an issue is closed and allows re-opening the issue with the same set of assignees.I adjusted existing tests to also examine
assigneesproperty for said operations.Before opening a new issue, please [search][] for a previously filed
issue to ensure you're not creating a duplicate.