Update Branch.sync_with_upstream to correcly send required data.#1199
Merged
sigmavirus24 merged 5 commits intosigmavirus24:mainfrom May 2, 2025
Merged
Update Branch.sync_with_upstream to correcly send required data.#1199sigmavirus24 merged 5 commits intosigmavirus24:mainfrom
Branch.sync_with_upstream to correcly send required data.#1199sigmavirus24 merged 5 commits intosigmavirus24:mainfrom
Conversation
sigmavirus24
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
data={"branch": self.name}to the request made byBranch.sync_with_upstream, in conformance with the corresponding API docs. Also removes the mention that this is a beta feature as I didn't see it in the docs. Contains new tests.Please let me know if there's anything I can do to improve the code, the PR itself or anything else.
Fixes #1198.
Thank you!