address pull request notes

Author: Teque5

sigmf/archive.py

@@ -76,38 +76,6 @@ def _get_archive_basename(path):
     return path.stem
 
 
-def _get_archive_basename(path):
-    """Get the archive base name (without any sigmf archive extension).
-
-    Parameters
-    ----------
-    path : Path
-        Archive file path.
-
-    Returns
-    -------
-    str
-        Base name without sigmf extension.
-
-    Examples
-    --------
-    >>> _get_archive_basename(Path("recording.sigmf"))
-    'recording'
-    >>> _get_archive_basename(Path("recording.sigmf.gz"))
-    'recording'
-    >>> _get_archive_basename(Path("my.recording.sigmf.zip"))
-    'my.recording'
-    """
-    name = path.name
-    # check compound extensions first (longest match)
-    for ext in sorted(SIGMF_COMPRESSED_EXTS.values(), key=len, reverse=True):
-        if name.endswith(ext):
-            return name[: -len(ext)]
-    if name.endswith(SIGMF_ARCHIVE_EXT):
-        return name[: -len(SIGMF_ARCHIVE_EXT)]
-    return path.stem
-
-
 class SigMFArchive:
     """
     Archive a SigMFFile into a tar or zip file, optionally with compression.

sigmf/sigmffile.py

@@ -633,7 +633,7 @@ def add_annotation(self, start_index, length=None, metadata=None):
         new_annot = metadata or {}
         new_annot[keys.SAMPLE_START_KEY] = start_index
         if length is not None:
-            if length <= 0:
+            if length < 0:
                 raise SigMFAccessError("Annotation `length` must be >= 0")
             new_annot[keys.SAMPLE_COUNT_KEY] = length
 
@@ -724,7 +724,7 @@ def _count_samples(self):
     def _get_sample_count_from_annotations(self):
         """
         Returns the number of samples based on annotation with highest end index.
-        NOTE: Annotations are ordered by START_INDEX_KEY and not end index, so we
+        NOTE: Annotations are ordered by SAMPLE_START_KEY and not end index, so we
         need to go through all annotations
         """
         annon_sample_count = []