converter homologation

Author: Teque5

sigmf/convert/blue.py

@@ -328,7 +328,7 @@ def data_loopback(blue_path: Path, data_path: Path, h_fixed: dict) -> None:
     numpy.ndarray
         Parsed samples. Empty array for zero-sample files.
     """
-    header_bytes, data_bytes, _ = _get_data_boundaries(blue_path, h_fixed)
+    header_bytes, data_bytes, _ = _get_blue_boundaries(blue_path, h_fixed)
     blue_format = h_fixed.get("format")
 
     # use header data_size field instead of file size calculation
@@ -371,7 +371,7 @@ def data_loopback(blue_path: Path, data_path: Path, h_fixed: dict) -> None:
     log.info("wrote SigMF dataset to %s", data_path)
 
 
-def _get_data_boundaries(blue_path: Path, h_fixed: dict) -> (int, int):
+def _get_blue_boundaries(blue_path: Path, h_fixed: dict) -> (int, int):
     """
     Extract data boundaries from fixed header.
     """
@@ -434,11 +434,6 @@ def _build_common_metadata(
     -------
     tuple[dict, dict]
         (global_info, capture_info) dictionaries.
-
-    Raises
-    ------
-    SigMFConversionError
-        If SigMF spec compliance is violated.
     """
     # helper to look up extended header values by tag
     def get_tag(tag):
@@ -516,16 +511,9 @@ def get_tag(tag):
         capture_info[SigMFFile.DATETIME_KEY] = blue_datetime.strftime(SIGMF_DATETIME_ISO8601_FMT)
 
     if get_tag("RF_FREQ") is not None:
-        # it's possible other keys indicate tune frequency, but RF_FREQ is standard
+        # it's possible other keys indicate tune frequency, but RF_FREQ is common
         capture_info[SigMFFile.FREQUENCY_KEY] = float(get_tag("RF_FREQ"))
 
-    # validate SigMF spec compliance: metadata_only and dataset fields are mutually exclusive
-    if SigMFFile.METADATA_ONLY_KEY in global_info and SigMFFile.DATASET_KEY in global_info:
-        raise SigMFConversionError(
-            "SigMF spec violation: core:metadata_only MAY NOT be used in conjunction with "
-            "Non-Conforming Datasets or the core:dataset field"
-        )
-
     return global_info, capture_info
 
 
@@ -709,7 +697,7 @@ def construct_sigmf_ncd(
     SigMFFile
         NCD SigMF object pointing to original BLUE file.
     """
-    header_bytes, data_bytes, trailing_bytes = _get_data_boundaries(blue_path, h_fixed)
+    header_bytes, data_bytes, trailing_bytes = _get_blue_boundaries(blue_path, h_fixed)
 
     # use shared helper to build common metadata, with NCD-specific additions
     global_info, capture_info = _build_common_metadata(

sigmf/convert/wav.py

@@ -12,7 +12,7 @@
 import wave
 from datetime import datetime, timezone
 from pathlib import Path
-from typing import Optional
+from typing import Optional, Tuple
 
 import numpy as np
 
@@ -25,7 +25,7 @@
 log = logging.getLogger()
 
 
-def _calculate_wav_ncd_bytes(wav_path: Path) -> tuple:
+def _get_wav_boundaries(wav_path: Path) -> Tuple[int, int]:
     """
     Calculate header_bytes and trailing_bytes for WAV NCD.
 
@@ -120,7 +120,7 @@ def wav_to_sigmf(
 
         # for NCD support, calculate precise byte boundaries
         if create_ncd:
-            header_bytes, trailing_bytes = _calculate_wav_ncd_bytes(wav_path)
+            header_bytes, trailing_bytes = _get_wav_boundaries(wav_path)
             log.debug(f"WAV NCD: header_bytes={header_bytes}, trailing_bytes={trailing_bytes}")
 
         # only read audio data if we're not creating NCD metadata-only