Migrate 5 java classes to kotlin#14857
Open
YasinMoridi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates 5 Java classes in the
org.thoughtcrime.securesmspackage to Kotlin as part of ongoing code modernization efforts.Files converted:
BlockUnblockDialog.java→BlockUnblockDialog.kt(converted toobjectwith@JvmStaticfor Java compatibility)KbsEnclave.java→KbsEnclave.kt(converted todata class)Unbindable.java→Unbindable.kt(converted to interface)MasterSecretListener.java→MasterSecretListener.kt(converted to interface)TextSecureExpiredException.java→TextSecureExpiredException.kt(converted to Exception class)Changes made:
whenexpressions, properties, null safety)Redeclarationerrors@JvmStaticannotations where neededTesting:
./gradlew buildNo new features or behavior changes are introduced in this PR.