Skip to content

Migrate 5 java classes to kotlin#14857

Open
YasinMoridi wants to merge 2 commits into
signalapp:mainfrom
YasinMoridi:Migrate-5-Java-classes-to-Kotlin
Open

Migrate 5 java classes to kotlin#14857
YasinMoridi wants to merge 2 commits into
signalapp:mainfrom
YasinMoridi:Migrate-5-Java-classes-to-Kotlin

Conversation

@YasinMoridi

Copy link
Copy Markdown

Description

This PR migrates 5 Java classes in the org.thoughtcrime.securesms package to Kotlin as part of ongoing code modernization efforts.

Files converted:

  • BlockUnblockDialog.javaBlockUnblockDialog.kt (converted to object with @JvmStatic for Java compatibility)
  • KbsEnclave.javaKbsEnclave.kt (converted to data class)
  • Unbindable.javaUnbindable.kt (converted to interface)
  • MasterSecretListener.javaMasterSecretListener.kt (converted to interface)
  • TextSecureExpiredException.javaTextSecureExpiredException.kt (converted to Exception class)

Changes made:

  • Used Kotlin idioms (when expressions, properties, null safety)
  • Removed original Java files to prevent Redeclaration errors
  • Maintained full compatibility with existing Java code via @JvmStatic annotations where needed

Testing:

  • Built the project successfully with ./gradlew build
  • No functional changes were introduced — this is a pure language migration
  • [Add any specific manual testing you did here]

No new features or behavior changes are introduced in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant