Best effort shutdown of opamp client#2738
Merged
breedx-splk merged 2 commits intosignalfx:mainfrom Apr 7, 2026
Merged
Conversation
robsunday
approved these changes
Apr 7, 2026
robsunday
reviewed
Apr 7, 2026
| () -> { | ||
| try { | ||
| client.close(); | ||
| } catch (IOException e) { |
Contributor
There was a problem hiding this comment.
I'd consider catching Exception here. If something else that IOException is thrown here, and stderr is not redirected to log then we may see nothing in logs.
Collaborator
There was a problem hiding this comment.
Imo it is not important. Often the exceptions that happen during shutdown are just noise anyway.
laurit
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.