Profiler configuration refactoring#2903
Merged
Merged
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Test improved
robsunday
commented
Jun 24, 2026
| DeclarativeConfigurationCustomizerProvider.class, | ||
| AutoConfigurationCustomizerProvider.class | ||
| }) | ||
| public class ProfilerConfigurationInitializer |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] This class configures ProfilerConfiguration.SUPPLIER with an instance of ProfilerConfiguration built by appropriate factory, depending on agent configuration type
laurit
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains refactoring of
ProfilerConfigurationand related classes. These changes are made with remote config in mind and are extracted part of remote config -> effective config feedback mechanism, just for easier review.Feedback mechanism is fully implemented in draft PR #2904
In scope:
ProfilerEnvVarConfigurationandProfilerDeclarativeConfigurationare replaced by a single class -ProfilerConfigurationProfilerConfigurationis created by a factory appropriate for the agent configuration flavor (ProfilerEnvVarsConfigurationFactory/ProfilerDeclarativeConfigurationFactory).ProfilerConfigurationis always available through ProfilerConfiguration.SUPPLIER