[OpAMP] Effective config feedback after remote config applied#2904
Open
robsunday wants to merge 10 commits into
Open
[OpAMP] Effective config feedback after remote config applied#2904robsunday wants to merge 10 commits into
robsunday wants to merge 10 commits into
Conversation
Test improved
# Conflicts: # opamp/src/main/java/com/splunk/opentelemetry/opamp/RemoteConfigProcessor.java # opamp/src/main/java/com/splunk/opentelemetry/opamp/effectiveconfig/EnvVarsEffectiveConfigFileFactory.java
robsunday
commented
Jun 25, 2026
| return new EffectiveConfigReporter(createEffectiveConfigFactory(sdk), effectiveConfigState); | ||
| } | ||
|
|
||
| public boolean reportEffectiveConfigIfChanged() { |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] It is the most basic approach, but is good enough for now. Effective config is recreated every time and compared with the one most recently reported. If identical then it is not sent again.
|
|
||
| ProfilerConfiguration updatedProfilerConfig = | ||
| ProfilerConfiguration.SUPPLIER.get().toBuilder() | ||
| .setEnabled(receivedProfilerConfig.isEnabled()) |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] Next configurable properties will go here
| .build(); | ||
| ProfilerConfiguration.SUPPLIER.configure(updatedProfilerConfig); | ||
|
|
||
| if (updatedProfilerConfig.isEnabled()) { |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] It will change in next PR, so other properties can be supported
|
Tick the box to add this pull request to the merge queue (same as
|
robsunday
commented
Jun 25, 2026
|
|
||
| public void set(AgentConfigMap configMap) { | ||
| agentConfigMap = configMap; | ||
| notifyUpdate(); |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] Automatically trigger sending message to the server with this state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effective config is now reported if profiler configuration changed.