Open
Conversation
…nvocation - Migrate from raw spans to TelemetryHandler lifecycle (start_llm/stop_llm/fail_llm) - Build LLMInvocation with text and tool-response message parts - Remove _StabilityMode branching, events.py, and completion_hook paths - Remove experimental test files (merged into main test suite)
…lResponse - Map function_call parts to ToolCall, function_response to ToolCallResponse - Populate request_functions from tool definitions (always, independent of content capture) - Add tests for function call spans, tool events, and request function attributes
shuwpan
force-pushed
the
HYBIM-634_vertexai-tool-calls
branch
from
1b54353 to
1d3984d
Compare
…itions with env var - Use invocation.tool_definitions instead of invocation.attributes[GEN_AI_TOOL_DEFINITIONS] - Gate tool_definitions with should_capture_tool_definitions() (OTEL_INSTRUMENTATION_GENAI_CAPTURE_TOOL_DEFINITIONS) - Use invocation.output_type instead of invocation.attributes[GEN_AI_OUTPUT_TYPE] - Set request_choice_count and request_top_k on LLMInvocation - Extract top_k from Vertex AI GenerationConfig - Add tests for tool_definitions opt-in behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #271 (HYBIM-623_replace_current_impl_with_LLMInvocation)
https://shw-playground.signalfx.com/#/apm/traces/c93e83b81d7259991bdfd33d3d0ff493?tab=waterfall
https://shw-playground.signalfx.com/#/apm/traces/c625f3403ea53bc0326215d5e1d0f2bf?tab=waterfall