mod_commands: fix nullptr crash in uuid_record when argc=4#3001
Open
jack3z wants to merge 2 commits into
Open
Conversation
Author
Additional NotesCrash stack trace: This is a critical stability fix for production environments using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a null pointer crash in
mod_commands.cwhen executing theuuid_recordAPI command.The bug was caused by an incorrect argument count check:
if (argc > 3)and accessedargv[4]directlyargc == 4,argv[4]is NULL, passing a null pointer toswitch_url_decode()switch_url_decodeatsrc/switch_utils.c:3540Fix: Changed the condition from
argc > 3toargc > 4to ensureargv[4]is valid before accessing it.Type of Change
Related Issues
No existing issue reported; this bug was discovered via production crash stack trace.
Testing
Manual testing verification:
uuid_recordwith 4 arguments (argc=4) → No crash, works safelyuuid_recordwith 5 arguments (argc=5) → Functions as expectedChecklist
Additional Notes
Crash stack trace: