Pass slot to randao reveal

Author: diegomrsantos

testing/web3signer_tests/src/lib.rs

@@ -591,9 +591,9 @@ mod tests {
         .await
         .assert_signatures_match("randao_reveal", |pubkey, validator_store| async move {
             validator_store
-                .randao_reveal(pubkey, Epoch::new(0))
+                .randao_reveal(pubkey, Slot::new(0))
                 .await
-                .unwrap()
+                .expect("randao reveal should sign")
         })
         .await
         .assert_signatures_match("beacon_block_base", |pubkey, validator_store| {

validator_client/lighthouse_validator_store/src/lib.rs

@@ -702,9 +702,10 @@ impl<T: SlotClock + 'static, E: EthSpec> ValidatorStore for LighthouseValidatorS
     async fn randao_reveal(
         &self,
         validator_pubkey: PublicKeyBytes,
-        signing_epoch: Epoch,
+        slot: Slot,
     ) -> Result<Signature, Error> {
         let signing_method = self.doppelganger_checked_signing_method(validator_pubkey)?;
+        let signing_epoch = slot.epoch(E::slots_per_epoch());
         let signing_context = self.signing_context(Domain::Randao, signing_epoch);
 
         let signature = signing_method

validator_client/validator_services/src/block_service.rs

@@ -409,7 +409,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> BlockService<S, T> {
 
         let randao_reveal = match self
             .validator_store
-            .randao_reveal(validator_pubkey, slot.epoch(S::E::slots_per_epoch()))
+            .randao_reveal(validator_pubkey, slot)
             .await
         {
             Ok(signature) => signature.into(),

validator_client/validator_store/src/lib.rs

@@ -88,10 +88,15 @@ pub trait ValidatorStore: Send + Sync {
     /// - Else return `None` to indicate no preference between builder and local payloads.
     fn determine_builder_boost_factor(&self, validator_pubkey: &PublicKeyBytes) -> Option<u64>;
 
+    /// Produce a RANDAO reveal for a block proposal at `slot`.
+    ///
+    /// The RANDAO message signs the epoch containing `slot`, but callers pass
+    /// the proposer slot so validator store implementations keep the full duty
+    /// context.
     fn randao_reveal(
         &self,
         validator_pubkey: PublicKeyBytes,
-        signing_epoch: Epoch,
+        slot: Slot,
     ) -> impl Future<Output = Result<Signature, Error<Self::Error>>> + Send;
 
     fn set_validator_index(&self, validator_pubkey: &PublicKeyBytes, index: u64);