fix: auto-pull latest Nethermind version in EL test#9282
Conversation
|
|
|
@rahulbarmann test is failing, could you fix it? |
|
Thanks for the heads-up @chong-he. Pushed a fix, Nethermind migrated their solution file from .sln to .slnx (XML format) somewhere between 1.27.0 and 1.37.2, so the build was failing at file resolution. Watching CI to see if anything else surfaces. |
|
Still failing. I face the same issue while trying to update the version when working on #9277. I ended up using a band-aid solution just to unblock the CI But if you have time to look into it, that will be great Edit: you can run the test locally |
|
Thanks @chong-he, I dug into the failing execution-engine integration job and fixed the latest-Nethermind breakages without re-pinning the version. The test now builds I verified locally with |
|
Thanks for the PR. Have you tried to remove the suppress warning that was added in #9277? Ideally we want to remove that and the test still passes |
|
Good point @chong-he. I tried removing I checked Nethermind upstream and noticed Do you think the right approach here is to resolve the latest stable |
I see. In that case we should still have the suppress warning for now. We can remove it later when 1.38.0 is released. |
Issue Addressed
Closes #9279.
Proposed Changes
release/1.27.0pin (temporary fix from Fix execution integration test CI failure #9277) with a helper that picks the latest stableMAJOR.MINOR.PATCHNethermind tag at build time. Resolves to1.37.2today.get_latest_releasebecause Nethermind tags recent releases onrelease/X.Y.Zbranches rather thanmaster,git describe origin/masterreturns1.14.1today. The new helper lists all tags with version-sort and picks the first stableMAJOR.MINOR.PATCHmatch.