Skip to content

fix: auto-pull latest Nethermind version in EL test#9282

Open
rahulbarmann wants to merge 3 commits into
sigp:unstablefrom
rahulbarmann:auto-pull-nethermind-version
Open

fix: auto-pull latest Nethermind version in EL test#9282
rahulbarmann wants to merge 3 commits into
sigp:unstablefrom
rahulbarmann:auto-pull-nethermind-version

Conversation

@rahulbarmann
Copy link
Copy Markdown

Issue Addressed

Closes #9279.

Proposed Changes

  • Replaces the release/1.27.0 pin (temporary fix from Fix execution integration test CI failure #9277) with a helper that picks the latest stable MAJOR.MINOR.PATCH Nethermind tag at build time. Resolves to 1.37.2 today.
  • Couldn't reuse get_latest_release because Nethermind tags recent releases on release/X.Y.Z branches rather than master, git describe origin/master returns 1.14.1 today. The new helper lists all tags with version-sort and picks the first stable MAJOR.MINOR.PATCH match.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 8, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 8, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chong-he
Copy link
Copy Markdown
Member

@rahulbarmann test is failing, could you fix it?

@chong-he chong-he added waiting-on-author The reviewer has suggested changes and awaits thier implementation. test improvement Improve tests labels May 11, 2026
@rahulbarmann
Copy link
Copy Markdown
Author

Thanks for the heads-up @chong-he. Pushed a fix, Nethermind migrated their solution file from .sln to .slnx (XML format) somewhere between 1.27.0 and 1.37.2, so the build was failing at file resolution.

Watching CI to see if anything else surfaces.

@chong-he
Copy link
Copy Markdown
Member

chong-he commented May 12, 2026

Still failing. I face the same issue while trying to update the version when working on #9277. I ended up using a band-aid solution just to unblock the CI

But if you have time to look into it, that will be great

Edit: you can run the test locally make test-exec-engine to see if it is passing or not

@rahulbarmann
Copy link
Copy Markdown
Author

Thanks @chong-he, I dug into the failing execution-engine integration job and fixed the latest-Nethermind breakages without re-pinning the version.

The test now builds Nethermind.Runner.csproj directly instead of the full solution, starts Nethermind with none.json plus the explicit test chainspec, and raises the Nethermind test genesis gas limit to match Geth so all 5 submitted transactions fit in the payload.

I verified locally with cargo fmt --check, cargo check, cargo test -p execution_engine_integration build_utils::tests, and the full make test-exec-engine against auto-selected Nethermind 1.37.2.

@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 14, 2026
@chong-he
Copy link
Copy Markdown
Member

Thanks for the PR.

Have you tried to remove the suppress warning that was added in #9277? Ideally we want to remove that and the test still passes

@rahulbarmann
Copy link
Copy Markdown
Author

Good point @chong-he. I tried removing -p:TreatWarningsAsErrors=false, but with the current auto-selected latest stable tag (1.37.2) the Nethermind build still fails on the same NU1903 warning for Snappier 1.3.0.

I checked Nethermind upstream and noticed release/1.38.0 has already bumped Snappier to 1.3.1, while the latest stable tag is still 1.37.2 with 1.3.0.

Do you think the right approach here is to resolve the latest stable release/X.Y.Z branch instead of the latest stable tag, so we can remove the warning suppression? Or would you prefer another approach?

@chong-he
Copy link
Copy Markdown
Member

Good point @chong-he. I tried removing -p:TreatWarningsAsErrors=false, but with the current auto-selected latest stable tag (1.37.2) the Nethermind build still fails on the same NU1903 warning for Snappier 1.3.0.

I checked Nethermind upstream and noticed release/1.38.0 has already bumped Snappier to 1.3.1, while the latest stable tag is still 1.37.2 with 1.3.0.

Do you think the right approach here is to resolve the latest stable release/X.Y.Z branch instead of the latest stable tag, so we can remove the warning suppression? Or would you prefer another approach?

I see. In that case we should still have the suppress warning for now. We can remove it later when 1.38.0 is released.

@chong-he chong-he self-requested a review May 20, 2026 01:18
@chong-he chong-he added under-review A reviewer has only partially completed a review. and removed ready-for-review The code is ready for review labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test improvement Improve tests under-review A reviewer has only partially completed a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants