Heze fork boilerplate#9573
Open
eserilev wants to merge 19 commits into
Open
Conversation
…ze-fork-boilerplate
…ighthouse into heze-fork-boilerplate
eserilev
force-pushed
the
heze-fork-boilerplate
branch
2 times, most recently
from
July 4, 2026 19:16
86db003 to
9a3ea67
Compare
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
mergify
Bot
added
ready-for-review
…ze-fork-boilerplate
…ighthouse into heze-fork-boilerplate
conache
reviewed
Jul 15, 2026
| let extra_fields = get_extra_fields(spec); | ||
|
|
||
| if spec.is_gloas_scheduled() { | ||
| if spec.is_heze_scheduled() { |
There was a problem hiding this comment.
Very small nit and it shouldn't be breaking for this PR, but flagging to keep it under the radar.
We should probably add a separate check for spec.is_heze_scheduled() in the following test helpers:
The tests using these helpers would fail when is_heze_scheduled() returns true, because the expected value becomes ConfigAndPreset::Heze, while the actual value is ConfigAndPreset::Gloas and the assertion would fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fork boilerplate for Heze
Written by AI, but I did a self review