Avoid redundant fork choice lookups in attestation verification#9577
Open
macladson wants to merge 1 commit into
Open
Avoid redundant fork choice lookups in attestation verification#9577macladson wants to merge 1 commit into
macladson wants to merge 1 commit into
Conversation
macladson
added
code-quality
optimization
macladson
force-pushed
the
dedupe-attestation-fork-choice-lookups
branch
from
a8aaf12 to
9307ddb
Compare
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
mergify
Bot
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
with_committee_cache/with_cached_shufflingalready perform a fork choicelookup internally to resolve the shuffling ID from the head block.
There are certain callers who take the fork choice read lock and look up the same block
immediately before calling it, which performs the lookup again.
Proposed Changes
Thread the pre-fetched block into the shuffling cache via new
with_committee_cache_for_block/with_cached_shuffling_for_blockmethods that takes the block instead of theroot, so we avoid the redundant lookup.