remove test-extension code

jxs · jxs · commit d995b3c65e24 · 2026-02-18T14:53:31.000Z
diff --git a/protocols/gossipsub/src/behaviour.rs b/protocols/gossipsub/src/behaviour.rs
@@ -2176,7 +2176,7 @@ where
 
                     #[cfg(feature = "partial_messages")]
                     self.partial_messages_extension
-                        .peer_unsubscribed(*propagation_source, &topic_hash);
+                        .peer_unsubscribed(*propagation_source, topic_hash);
 
                     unsubscribed_peers.push((*propagation_source, topic_hash.clone()));
                     // generate an unsubscribe event to be polled
@@ -3656,10 +3656,6 @@ where
                     self.handle_prune(&propagation_source, prune_msgs);
                 }
 
-                if let Some(_extension) = rpc.test_extension {
-                    tracing::debug!("Received Test Extension");
-                }
-
                 #[cfg(feature = "partial_messages")]
                 if let Some(partial_message) = rpc.partial_message {
                     if self
diff --git a/protocols/gossipsub/src/behaviour/tests/gossip.rs b/protocols/gossipsub/src/behaviour/tests/gossip.rs
@@ -207,7 +207,6 @@ fn test_handle_iwant_msg_but_already_sent_idontwant() {
     let rpc = RpcIn {
         messages: vec![],
         subscriptions: vec![],
-        test_extension: None,
         #[cfg(feature = "partial_messages")]
         partial_message: None,
         control_msgs: vec![ControlAction::IDontWant(IDontWant {
diff --git a/protocols/gossipsub/src/behaviour/tests/idontwant.rs b/protocols/gossipsub/src/behaviour/tests/idontwant.rs
@@ -225,7 +225,6 @@ fn parses_idontwant() {
     let rpc = RpcIn {
         messages: vec![],
         subscriptions: vec![],
-        test_extension: None,
         #[cfg(feature = "partial_messages")]
         partial_message: None,
         control_msgs: vec![ControlAction::IDontWant(IDontWant {
diff --git a/protocols/gossipsub/src/behaviour/tests/mod.rs b/protocols/gossipsub/src/behaviour/tests/mod.rs
@@ -546,7 +546,6 @@ pub(super) fn proto_to_message(rpc: &proto::RPC) -> RpcIn {
             })
             .collect(),
         control_msgs,
-        test_extension: None,
         #[cfg(feature = "partial_messages")]
         partial_message: None,
     }
diff --git a/protocols/gossipsub/src/behaviour/tests/partial.rs b/protocols/gossipsub/src/behaviour/tests/partial.rs
@@ -1,7 +1,6 @@
 use core::slice;
 use std::collections::{BTreeSet, HashMap, HashSet};
 
-use hashlink::LinkedHashMap;
 use libp2p_core::{Multiaddr, PeerId};
 use libp2p_swarm::{ConnectionId, NetworkBehaviour, ToSwarm};
 
@@ -15,80 +14,10 @@ use crate::{
         Metadata, Partial, PartialAction, PartialError, PartialMessage, PublishAction,
         ReceivedAction, State, DEFAULT_PARTIAL_TTL,
     },
-    queue::Queue,
-    types::{
-        ControlAction, Extensions, IHave, PeerDetails, PeerKind, RpcIn, RpcOut, SubscriptionOpts,
-    },
-    Behaviour, ConfigBuilder, Event, MessageAuthenticity, TopicHash, ValidationMode,
+    types::{IHave, PeerKind, RpcIn, RpcOut, SubscriptionOpts},
+    ConfigBuilder, Event, TopicHash, ValidationMode,
 };
 
-#[test]
-fn test_handle_extensions_message() {
-    let mut gs: Behaviour = Behaviour::new(
-        MessageAuthenticity::Anonymous,
-        ConfigBuilder::default()
-            .validation_mode(ValidationMode::None)
-            .build()
-            .unwrap(),
-    )
-    .unwrap();
-
-    let peer_id = PeerId::random();
-    let messages = Queue::new(gs.config.connection_handler_queue_len());
-
-    // Add peer without extensions
-    gs.connected_peers.insert(
-        peer_id,
-        PeerDetails {
-            kind: PeerKind::Gossipsubv1_3,
-            connections: vec![ConnectionId::new_unchecked(0)],
-            outbound: false,
-            topics: BTreeSet::new(),
-            messages,
-            dont_send: LinkedHashMap::new(),
-            extensions: None,
-        },
-    );
-
-    // Simulate receiving extensions message
-    let extensions = Extensions {
-        test_extension: Some(false),
-        partial_messages: None,
-    };
-    gs.handle_extensions(&peer_id, extensions);
-
-    // Verify extensions were stored
-    let peer_details = gs.connected_peers.get(&peer_id).unwrap();
-    assert!(peer_details.extensions.is_some());
-
-    // Simulate receiving duplicate extensions message from another peer
-    let duplicate_rpc = RpcIn {
-        messages: vec![],
-        subscriptions: vec![],
-        control_msgs: vec![ControlAction::Extensions(Some(Extensions {
-            test_extension: Some(true),
-            partial_messages: None,
-        }))],
-        test_extension: None,
-        #[cfg(feature = "partial_messages")]
-        partial_message: None,
-    };
-
-    gs.on_connection_handler_event(
-        peer_id,
-        ConnectionId::new_unchecked(0),
-        HandlerEvent::Message {
-            rpc: duplicate_rpc,
-            invalid_messages: vec![],
-        },
-    );
-
-    // Extensions should still be present (not cleared or changed)
-    let peer_details = gs.connected_peers.get(&peer_id).unwrap();
-    let test_extension = peer_details.extensions.unwrap().test_extension.unwrap();
-    assert!(!test_extension);
-}
-
 /// A simple bitmap-based test implementation of the `Partial` trait.
 /// Uses a fixed number of parts where each part is represented by a bit in a u8 bitmap.
 #[derive(Clone, Debug)]
@@ -1652,7 +1581,6 @@ fn test_partial_messages_two_node_exchange() {
                 messages: vec![],
                 subscriptions: vec![],
                 control_msgs: vec![],
-                test_extension: None,
                 partial_message: Some(node2_partial),
             },
             invalid_messages: vec![],
@@ -1890,7 +1818,6 @@ fn test_partial_messages_response_on_receive() {
                 messages: vec![],
                 subscriptions: vec![],
                 control_msgs: vec![],
-                test_extension: None,
                 partial_message: Some(peer_partial),
             },
             invalid_messages: vec![],
diff --git a/protocols/gossipsub/src/behaviour/tests/scoring.rs b/protocols/gossipsub/src/behaviour/tests/scoring.rs
@@ -684,7 +684,6 @@ fn test_ignore_rpc_from_peers_below_graylist_threshold() {
                 messages: vec![raw_message1],
                 subscriptions: vec![subscription.clone()],
                 control_msgs: vec![control_action],
-                test_extension: None,
                 #[cfg(feature = "partial_messages")]
                 partial_message: None,
             },
@@ -713,7 +712,6 @@ fn test_ignore_rpc_from_peers_below_graylist_threshold() {
                 messages: vec![raw_message3],
                 subscriptions: vec![subscription],
                 control_msgs: vec![control_action],
-                test_extension: None,
                 #[cfg(feature = "partial_messages")]
                 partial_message: None,
             },
@@ -1310,7 +1308,6 @@ fn test_scoring_p4_invalid_signature() {
                 messages: vec![],
                 subscriptions: vec![],
                 control_msgs: vec![],
-                test_extension: None,
                 #[cfg(feature = "partial_messages")]
                 partial_message: None,
             },
diff --git a/protocols/gossipsub/src/behaviour/tests/topic_config.rs b/protocols/gossipsub/src/behaviour/tests/topic_config.rs
@@ -636,7 +636,6 @@ fn test_validation_error_message_size_too_large_topic_specific() {
                 messages: vec![raw_message],
                 subscriptions: vec![],
                 control_msgs: vec![],
-                test_extension: None,
                 #[cfg(feature = "partial_messages")]
                 partial_message: None,
             },
@@ -745,7 +744,6 @@ fn test_validation_message_size_within_topic_specific() {
                 messages: vec![raw_message],
                 subscriptions: vec![],
                 control_msgs: vec![],
-                test_extension: None,
                 #[cfg(feature = "partial_messages")]
                 partial_message: None,
             },
diff --git a/protocols/gossipsub/src/protocol.rs b/protocols/gossipsub/src/protocol.rs
@@ -39,7 +39,6 @@ use crate::{
     types::{
         ControlAction, Extensions, Graft, IDontWant, IHave, IWant, MessageId, PeerInfo, PeerKind,
         Prune, RawMessage, RpcIn, Subscription, SubscriptionAction, SubscriptionOpts,
-        TestExtension,
     },
     ValidationError,
 };
@@ -619,7 +618,6 @@ impl Decoder for GossipsubCodec {
                     })
                     .collect(),
                 control_msgs,
-                test_extension: rpc.testExtension.map(|_test_extension| TestExtension {}),
                 #[cfg(feature = "partial_messages")]
                 partial_message,
             },
diff --git a/protocols/gossipsub/src/types.rs b/protocols/gossipsub/src/types.rs
@@ -336,9 +336,6 @@ pub struct Extensions {
     pub(crate) partial_messages: Option<bool>,
 }
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
-pub struct TestExtension {}
-
 /// A Gossipsub RPC message sent.
 #[derive(Debug)]
 pub enum RpcOut {
@@ -607,8 +604,6 @@ pub struct RpcIn {
     pub subscriptions: Vec<Subscription>,
     /// List of Gossipsub control messages.
     pub control_msgs: Vec<ControlAction>,
-    /// Gossipsub test extension.
-    pub test_extension: Option<TestExtension>,
     /// Partial messages extension.
     #[cfg(feature = "partial_messages")]
     pub partial_message: Option<crate::extensions::partial_messages::PartialMessage>,

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,6 @@ pub(super) fn proto_to_message(rpc: &proto::RPC) -> RpcIn {`
`546`	`546`	`})`
`547`	`547`	`.collect(),`
`548`	`548`	`control_msgs,`
`549`		`- test_extension: None,`
`550`	`549`	`#[cfg(feature = "partial_messages")]`
`551`	`550`	`partial_message: None,`
`552`	`551`	`}`