Skip to content

Support more hash/signing algorithms#1198

Merged
loosebazooka merged 2 commits into
mainfrom
algo2
Jun 3, 2026
Merged

Support more hash/signing algorithms#1198
loosebazooka merged 2 commits into
mainfrom
algo2

Conversation

@loosebazooka

Copy link
Copy Markdown
Member

Summary

Release Note

Documentation

@loosebazooka loosebazooka requested a review from aaronlew02 June 1, 2026 14:53
@loosebazooka

loosebazooka commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

actually, the signing algorithm mapping only really applies to rekor v2 dsseXhashedrekord. We have some legacy bundles that mix and match keys + hash algorithm. I need to rethink this whole thing

Signed-off-by: Appu <appu@google.com>
@loosebazooka

Copy link
Copy Markdown
Member Author

okay better, this is ready for review

@aaronlew02 aaronlew02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a couple of comments.

Comment thread sigstore-java/src/main/java/dev/sigstore/encryption/Hashers.java Outdated
Signed-off-by: Appu <appu@google.com>
@loosebazooka

Copy link
Copy Markdown
Member Author

okay switched rsa to sha256 only

@loosebazooka loosebazooka merged commit 0e587f0 into main Jun 3, 2026
21 checks passed
@loosebazooka loosebazooka deleted the algo2 branch June 3, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants