Skip to content

Use Sigstore staging TSA in timestamp client #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronlew02 merged 1 commit into from
Jun 2, 2025
Merged

Use Sigstore staging TSA in timestamp client #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import com.google.api.client.http.HttpRequestFactory;
import dev.sigstore.http.HttpClients;
import dev.sigstore.http.HttpParams;
import dev.sigstore.http.ImmutableHttpParams;
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.security.MessageDigest;
import okhttp3.mockwebserver.MockResponse;
Expand All @@ -36,19 +31,12 @@
import org.junit.jupiter.api.Test;

public class TimestampClientHttpTest {
private static HttpRequestFactory requestFactory;
private static HttpParams httpParams;
private static TimestampRequest tsReq;

private static final byte[] INVALID_TS_RESP_BYTES = new byte[14];
private static final URI SIGSTORE_TSA_URI =
URI.create("https://timestamp.sigstage.dev/api/v1/timestamp");

@BeforeAll
public static void setup() throws Exception {
httpParams = ImmutableHttpParams.builder().build();
requestFactory = HttpClients.newRequestFactory(httpParams);

var digest = MessageDigest.getInstance("SHA-256");
var artifactHashBytes = digest.digest("test".getBytes(StandardCharsets.UTF_8));
tsReq =
Expand All @@ -60,7 +48,7 @@ public static void setup() throws Exception {

@Test
public void timestamp_success() throws Exception {
var client = new TimestampClientHttp(requestFactory, SIGSTORE_TSA_URI);
var client = TimestampClientHttp.builder().build();

var tsResp = client.timestamp(tsReq);

Expand Down Expand Up @@ -92,7 +80,7 @@ public void timestamp_failure_badResponse_incorrectDigestLength() throws Excepti
.nonce(tsReq.getNonce())
.build();

var client = new TimestampClientHttp(requestFactory, SIGSTORE_TSA_URI);
var client = TimestampClientHttp.builder().build();

var tse =
assertThrows(
Expand All @@ -112,7 +100,7 @@ public void timestamp_failure_badResponse_nonRetryableError() throws Exception {
server.start();

var tsaUri = server.url("/v1/timestamp/").uri();
var client = new TimestampClientHttp(requestFactory, tsaUri);
var client = TimestampClientHttp.builder().setUri(tsaUri).build();

var tse =
assertThrows(
Expand All @@ -134,7 +122,7 @@ public void timestamp_failure_badResponse_RetryableError() throws Exception {
server.start();

var tsaUri = server.url("/v1/timestamp/").uri();
var client = new TimestampClientHttp(requestFactory, tsaUri);
var client = TimestampClientHttp.builder().setUri(tsaUri).build();

var tse =
assertThrows(
Expand All @@ -156,7 +144,7 @@ public void timestamp_failure_invalidResponseFormat() throws Exception {
server.start();

var tsaUri = server.url("/v1/timestamp/").uri();
var client = new TimestampClientHttp(requestFactory, tsaUri);
var client = TimestampClientHttp.builder().setUri(tsaUri).build();

var tse =
assertThrows(
Expand All @@ -180,7 +168,7 @@ public void timestamp_failure_responseBodyReadError() throws Exception {
server.start();

var tsaUri = server.url("/v1/timestamp/").uri();
var client = new TimestampClientHttp(requestFactory, tsaUri);
var client = TimestampClientHttp.builder().setUri(tsaUri).build();

var tse =
assertThrows(
Expand Down
Loading