Remove DockerHub push#307
Merged
Merged
Conversation
mtompset
approved these changes
Jan 28, 2026
Contributor
|
Should this change be highlighted in the README since this is used by others? |
Appears to not need the additional parameters.
Contributor
Author
|
@briskt I needed to adjust the install for |
mtompset
reviewed
Jan 30, 2026
briskt
approved these changes
Feb 2, 2026
Contributor
briskt
left a comment
briskt
left a comment
There was a problem hiding this comment.
Looks OK to me, though I think some mention should be made, in a prominent place like the README, about dropping the Docker Hub image. But in reality I think nobody, including our team, uses the Docker image at all. We just pull the script directly from GitHub. So I'd recommend deleting the entire build/push and just leave the test.
Contributor
Author
|
@briskt I have added a note in the README about how we have migrated the container image to GHCR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed