Merge pull request #38 from silinternational/autocomplete-no-no

user and pass inputs could've been a little more secure.

Author: longrunningprocess

themes/material/core/loginuserpass.php

@@ -44,7 +44,7 @@ function onRecaptchaLoad() {
     <main class="mdl-layout__content" layout-children="column" child-spacing="center">
         <?php include __DIR__ . '/../common-announcement.php' ?>
 
-        <form method="post">
+        <form method="post" autocomplete="off">
             <input type="hidden" name="AuthState"
                    value="<?= htmlentities($this->data['stateparams']['AuthState']) ?>" />
             <?php
@@ -73,8 +73,8 @@ function onRecaptchaLoad() {
                         $username = htmlentities($this->data['username'] ?? null);
                         ?>
                         <input type="text" name="username" class="mdl-textfield__input"
-                               value="<?= $username ?>"
-                               <?= empty($username) ? 'autofocus' : '' ?> id="username"/>
+                               value="<?= $username ?>" <?= empty($username) ? 'autofocus' : '' ?>
+                               id="username"/>
                     </div>
 
                     <div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label">

themes/material/mfa/prompt-for-mfa-backupcode.php

@@ -15,7 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column" method="post">
+        <form layout-children="column" method="post" autocomplete="off">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-backupcode.svg"
@@ -40,7 +40,7 @@
                             <?= $this->t('{material:mfa:backupcode_input}') ?>
                         </label>
                         <input name="mfaSubmission" class="mdl-textfield__input" autofocus
-                               id="mfaSubmission" autocomplete="off" />
+                               id="mfaSubmission" />
                     </div>
                 </div>
 

themes/material/mfa/prompt-for-mfa-totp.php

@@ -15,7 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column" method="post">
+        <form layout-children="column" method="post" autocomplete="off">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-totp.svg" alt="<?= $this->t('{material:mfa:totp_icon}') ?>">
@@ -39,7 +39,7 @@
                             <?= $this->t('{material:mfa:totp_input}') ?>
                         </label>
                         <input name="mfaSubmission" class="mdl-textfield__input" autofocus
-                               id="mfaSubmission" autocomplete="off" />
+                               id="mfaSubmission" />
                     </div>
                 </div>