Skip to content

Add fallback math helper coverage #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gwani-28 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add fallback math helper coverage #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions test/operators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@ function assertCloseTo(expected, actual, delta) {
return assert.ok(Math.abs(expected - actual) <= delta);
}

function withNativeMathUnavailable(names, callback) {
var original = {};
names.forEach(function (name) {
original[name] = Math[name];
Math[name] = null;
});

try {
callback();
} finally {
names.forEach(function (name) {
Math[name] = original[name];
});
}
}

describe('Operators', function () {
var parser = new Parser();

Expand Down Expand Up @@ -1026,4 +1042,21 @@ describe('Operators', function () {
assertCloseTo(parser.parse('log2 x').toJSFunction('x')(3), 1.584962500721156, delta);
});
});

describe('fallback math implementations', function () {
it('uses fallback implementations when native Math helpers are unavailable', function () {
withNativeMathUnavailable(['expm1', 'log1p', 'log2'], function () {
var fallbackParser = new Parser();
var delta = 1e-15;

assertCloseTo(fallbackParser.evaluate('expm1 1'), 1.718281828459045, delta);
assertCloseTo(fallbackParser.evaluate('log1p 9'), 2.302585092994046, delta);
assertCloseTo(fallbackParser.evaluate('log2 8'), 3, delta);

assertCloseTo(fallbackParser.parse('expm1 x').toJSFunction('x')(2), 6.38905609893065, delta);
assertCloseTo(fallbackParser.parse('log1p x').toJSFunction('x')(1), 0.6931471805599453, delta);
assertCloseTo(fallbackParser.parse('log2 x').toJSFunction('x')(3), 1.584962500721156, delta);
});
});
});
});