Fix LT-22290: Crash on deleting disapproved wordform analysis (#473)

jtmaxwell3 · web-flow · commit 19deac86f4c5 · 2025-09-25T20:05:10.000Z
diff --git a/Src/LexText/Morphology/MorphologyListener.cs b/Src/LexText/Morphology/MorphologyListener.cs
@@ -790,7 +790,7 @@ public virtual bool OnDisplayAnalysisApprove(object commandObject,
 			ref UIItemDisplayProperties display)
 		{
 			display.Enabled = display.Visible = InFriendlyArea;
-			display.Checked = Analysis != null && Analysis.ApprovalStatusIcon == 1;
+			display.Checked = Analysis != null && Analysis.IsValidObject && Analysis.ApprovalStatusIcon == 1;
 			return true; //we've handled this
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -790,7 +790,7 @@ public virtual bool OnDisplayAnalysisApprove(object commandObject,`
`790`	`790`	`ref UIItemDisplayProperties display)`
`791`	`791`	`{`
`792`	`792`	`display.Enabled = display.Visible = InFriendlyArea;`
`793`		`- display.Checked = Analysis != null && Analysis.ApprovalStatusIcon == 1;`
	`793`	`+ display.Checked = Analysis != null && Analysis.IsValidObject && Analysis.ApprovalStatusIcon == 1;`
`794`	`794`	`return true; //we've handled this`
`795`	`795`	`}`
`796`	`796`