More progress

Author: johnml1135

.github/skills/fieldworks-installer-diagnostics/SKILL.md

@@ -37,6 +37,7 @@ When the WinApp MCP server is available, use it to make UI diagnostics repeatabl
 - Record the observed focus path and control names in the evidence notes, especially for silent/blank UI, MSI handoff, uninstall prompts, and ARP uninstall hangs.
 - For safe UI-only smoke tests, stop after proving the license checkbox/Install/Cancel path; do not proceed into install unless the scenario requires machine changes.
 - For hangs, combine WinApp focused-element/window evidence with bundle/MSI logs, before/after snapshots, Event Viewer entries, and process lists.
+- If the bundle reaches elevated MSI internal UI, a non-elevated WinApp host may be limited to observation. Treat visible-but-non-clickable MSI controls as an automation integrity boundary until proven otherwise; capture the focused element, MSI log action, screenshots, process integrity/window ownership evidence, and rerun elevated for full manual UI control.
 
 ## Commands
 

.github/skills/fieldworks-wix6-ui/SKILL.md

@@ -67,6 +67,8 @@ Use WinApp MCP for bundle/MSI UI smoke tests whenever the server is available.
 
 Known behavior: the Burn launcher PID may not own the visible WixStdBA window after startup. If `get_snapshot` returns no accessible elements, use desktop window discovery, `get_focused_element`, keyboard commands, or coordinate clicks rather than concluding the UI is untestable.
 
+Elevation boundary: a non-elevated VS Code/WinApp MCP host can usually drive the bundle UI before elevation, but may only observe the elevated MSI internal UI. If the MSI welcome dialog shows focus on `&Next` but UIA click, keyboard, coordinate click, and direct button messages do not advance it, rerun with an elevated automation host or switch to quiet install/uninstall evidence for completion.
+
 ## Evidence Checklist
 
 - Bundle command and UI level used.

.github/skills/fieldworks-wix6-upgrade-patching/SKILL.md

@@ -69,6 +69,7 @@ Use WinApp MCP to observe and drive UI during upgrade, repair, and uninstall evi
 - For ARP uninstall hangs, use WinApp to identify whether focus is on a hidden prompt, MSI dialog, bundle confirmation, or UAC-adjacent window before changing authoring.
 - During WiX 3 to WiX 6 upgrade tests, use WinApp screenshots/focus traces for the bundle welcome/license page, MSI destination folders page, feature tree, progress, completion, and any maintenance prompt.
 - Do not use WinApp to bypass prompts silently. The point is to document and reproduce the user-visible path while bundle/MSI logs and snapshots capture the underlying state.
+- Run the WinApp automation host elevated for full manual upgrade or uninstall UI once Burn hands off to MSI internal UI. A non-elevated host can observe the elevated MSI dialog but may not be able to click `Next`, `Repair`, `Uninstall`, or ARP prompts.
 
 ## MSP Patch Gate
 

.github/workflows/CI.yml

@@ -5,6 +5,15 @@ on:
   pull_request:
     branches: ["release/**", "main", "feature/PubSub"]
   workflow_dispatch:
+    inputs:
+      run_wix6_installer_check:
+        description: 'Run the opt-in WiX 6 quiet install/uninstall verification on the GitHub runner'
+        required: false
+        default: 'false'
+        type: choice
+        options:
+          - 'false'
+          - 'true'
 
 permissions:
   contents: read
@@ -130,7 +139,14 @@ jobs:
       - name: Audit WiX 6 installer evidence
         shell: powershell
         run: |
-          .\Build\Agent\Test-Wix6InstallerBuildEvidence.ps1 -Configuration Release -Platform x64 -BuildLogPath .\wix6-installer-build.log -ReportPath .\Output\InstallerEvidence\wix6-ci-build-audit.txt
+          .\Build\Agent\Test-Wix6InstallerBuildEvidence.ps1 -Configuration Release -Platform x64 -BuildLogPath .\wix6-installer-build.log -ReportPath .\Output\InstallerEvidence\wix6-ci-build-audit.txt -RequireNoWix3ToolsOnPath
+          if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
+
+      - name: Run opt-in WiX 6 installer verification
+        if: ${{ github.event_name == 'workflow_dispatch' && inputs.run_wix6_installer_check == 'true' }}
+        shell: powershell
+        run: |
+          .\scripts\Agent\Invoke-InstallerCheck.ps1 -InstallerType Bundle -InstallerToolset Wix6 -Configuration Release -Platform x64 -RunId wix6-ci-install-check -InstallArguments @('/quiet','/norestart') -InstallTimeoutSeconds 3600 -RunUninstall -UninstallArguments @('/uninstall','/quiet','/norestart') -UninstallTimeoutSeconds 1800
           if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
 
       - name: Upload WiX 6 installer artifacts

.github/workflows/base-installer-cd.yml

@@ -139,7 +139,7 @@ jobs:
       - name: Setup dotnet
         uses: actions/setup-dotnet@v5
         with:
-          dotnet-version: | 
+          dotnet-version: |
             3.1.x
             5.0.x
 
@@ -172,11 +172,11 @@ jobs:
           $results = Select-String -Path "build.log" -Pattern "^\s*[1-9][0-9]* Error\(s\)"
           if ($results) {
               foreach ($result in $results) {
-                  Write-Host "Found errors in build.log $($result.LineNumber): $($result.Line)" -ForegroundColor red 
+                  Write-Host "Found errors in build.log $($result.LineNumber): $($result.Line)" -ForegroundColor red
               }
               exit 1
           } else {
-              Write-Host "No errors found" -ForegroundColor green 
+              Write-Host "No errors found" -ForegroundColor green
               exit 0
           }
 
@@ -251,24 +251,24 @@ jobs:
         run: |
           $offlineExe = "${{ steps.stage_installers.outputs.offline_exe }}"
           $onlineExe = "${{ steps.stage_installers.outputs.online_exe }}"
-          
+
           if (-not (Test-Path $offlineExe)) {
             throw "Offline installer not found at $offlineExe"
           }
           if (-not (Test-Path $onlineExe)) {
             throw "Online installer not found at $onlineExe"
           }
-          
+
           $offlineFile = Split-Path $offlineExe -Leaf
           $onlineFile = Split-Path $onlineExe -Leaf
-          
+
           $s3BasePath = "jobs/FieldWorks-Win-all-Release-Base/$($env:FW_BUILD_NUMBER)"
           $offlineS3Key = "$s3BasePath/$offlineFile"
           $onlineS3Key = "$s3BasePath/$onlineFile"
-          
+
           aws s3 cp $offlineExe "s3://flex-updates/$offlineS3Key"
           Write-Host "Uploaded offline installer to s3://flex-updates/$offlineS3Key"
-          
+
           aws s3 cp $onlineExe "s3://flex-updates/$onlineS3Key"
           Write-Host "Uploaded online installer to s3://flex-updates/$onlineS3Key"
 

.github/workflows/patch-installer-cd.yml

@@ -153,7 +153,7 @@ jobs:
       - name: Setup dotnet
         uses: actions/setup-dotnet@v5
         with:
-          dotnet-version: | 
+          dotnet-version: |
             3.1.x
             5.0.x
 
@@ -168,7 +168,7 @@ jobs:
           choco install wixtoolset --version 3.11.2 --allow-downgrade --force
           echo "C:\Program Files (x86)\WiX Toolset v3.11\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
         if: github.event_name != 'pull_request'
-        
+
       - name: Import Base Build Artifacts
         shell: pwsh
         run: |
@@ -213,7 +213,7 @@ jobs:
           )
           $valueName = "Switch.System.DisableTempFileCollectionDirectoryFeature"
           $expectedValue = "true"
-          
+
           foreach ($path in $regPaths) {
               Write-Host "Adding or updating registry value in $path..."
               if (-not (Test-Path $path)) {
@@ -240,11 +240,11 @@ jobs:
           $results = Select-String -Path "build.log" -Pattern "^\s*[1-9][0-9]* Error\(s\)"
           if ($results) {
               foreach ($result in $results) {
-                  Write-Host "Found errors in build.log $($result.LineNumber): $($result.Line)" -ForegroundColor red 
+                  Write-Host "Found errors in build.log $($result.LineNumber): $($result.Line)" -ForegroundColor red
               }
               exit 1
           } else {
-              Write-Host "No errors found" -ForegroundColor green 
+              Write-Host "No errors found" -ForegroundColor green
               exit 0
           }