Download Charis SIL test font instead of committing it

The Views shaping tests bundled CharisSIL 5.000 in the repo. Instead,
download Charis SIL 6.200 from a pinned GitHub release at build time into
the git-ignored Downloads/ and copy it beside TestViews.exe; remove the
committed font.

The OpenType metrics test moves from liga to smcp: in Charis 6.x the
fi/ffi ligatures keep the component advance widths, so liga changes the
rendered glyphs (still covered by the pixel tests) without changing
segment metrics, whereas small caps do change advance width.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: 2 people

Build/PackageRestore.targets

@@ -35,6 +35,10 @@
 		<!-- Scheherazade New: deterministic Arabic font for the render-snapshot tests; download from
 		     GitHub release (https://github.com/silnrsi/font-scheherazade/releases). -->
 		<ScheherazadeNewVersion>4.500</ScheherazadeNewVersion>
+		<!-- Charis SIL: test font for the Views Uniscribe/Graphite shaping tests; download from
+		     GitHub release (https://github.com/silnrsi/font-charis/releases). v6.x keeps the
+		     "Charis SIL" family name (v7 renames it to "Charis"). -->
+		<CharisSilVersion>6.200</CharisSilVersion>
 		<!-- PackagesDir: Use local packages folder. -->
 		<PackagesDir>$(fwrt)/packages</PackagesDir>
 	</PropertyGroup>
@@ -291,6 +295,20 @@
 			DownloadsDir="$(DownloadsDir)"
 			Condition="'$(OS)'=='Windows_NT' AND !Exists('$(DownloadsDir)/TonePars64.exe')"
 		/>
+		<!-- Charis SIL font: test font for the Views shaping tests (TestViews). Downloaded once into
+		     Downloads/ and unzipped there; TestViews.vcxproj copies the regular face into its output.
+		     Pinned to a release rather than committed to the repo. -->
+		<DownloadFile
+			Address="https://github.com/silnrsi/font-charis/releases/download/v$(CharisSilVersion)/CharisSIL-$(CharisSilVersion).zip"
+			LocalFilename="CharisSIL-$(CharisSilVersion).zip"
+			DownloadsDir="$(DownloadsDir)"
+			Condition="'$(OS)'=='Windows_NT' AND !Exists('$(DownloadsDir)/CharisSIL-$(CharisSilVersion).zip')"
+		/>
+		<Unzip
+			ZipFilename="$(DownloadsDir)/CharisSIL-$(CharisSilVersion).zip"
+			ToDir="$(DownloadsDir)/CharisSIL"
+			Condition="'$(OS)'=='Windows_NT' AND Exists('$(DownloadsDir)/CharisSIL-$(CharisSilVersion).zip') AND !Exists('$(DownloadsDir)/CharisSIL/CharisSIL-$(CharisSilVersion)/CharisSIL-Regular.ttf')"
+		/>
 		<!-- Scheherazade New font: deterministic Arabic glyph source for the render-snapshot tests
 		     (RootSiteTests). Downloaded once into Downloads/ and unzipped there; RootSiteTests copies
 		     the regular face into its test output. Pinned to a release so all machines/CI render

Src/views/Test/TestData/Fonts/CharisSIL-5.000/CharisSIL-R.ttf

@@ -201,7 +201,7 @@ namespace TestViews
 				pchLastSlash != NULL);
 			*(pchLastSlash + 1) = 0;
 			wcscat_s(rgchPath, _countof(rgchPath),
-				L"TestData\\Fonts\\CharisSIL-5.000\\CharisSIL-R.ttf");
+				L"TestData\\Fonts\\CharisSIL\\CharisSIL-Regular.ttf");
 
 			DWORD dwAttributes = ::GetFileAttributesW(rgchPath);
 			unitpp::assert_true("Charis SIL test font should be copied beside TestViews.exe",
@@ -324,15 +324,19 @@ namespace TestViews
 			unitpp::assert_true("Charis SIL test font should load", font.Loaded());
 			SetDefaultFontForTest(L"Charis SIL");
 
-			int dxWithoutLigatures = MeasureTextWithFeatures(L"office official affinity", L"liga=0");
-			int dxWithLigatures = MeasureTextWithFeatures(L"office official affinity", L"liga=1");
+			// Small caps replace lowercase letters with glyphs of different advance widths, so the
+			// measured segment width changes. (The liga feature was previously used here, but in
+			// Charis SIL 6.x the fi/ffi ligatures keep the component advance widths, so liga changes
+			// the rendered glyphs without changing segment metrics.)
+			int dxWithoutSmallCaps = MeasureTextWithFeatures(L"small caps verify", L"smcp=0");
+			int dxWithSmallCaps = MeasureTextWithFeatures(L"small caps verify", L"smcp=1");
 
 			unitpp::assert_true("OpenType feature-off segment width should be positive",
-				dxWithoutLigatures > 0);
+				dxWithoutSmallCaps > 0);
 			unitpp::assert_true("OpenType feature-on segment width should be positive",
-				dxWithLigatures > 0);
-			unitpp::assert_true("Charis SIL liga feature should change segment metrics",
-				dxWithoutLigatures != dxWithLigatures);
+				dxWithSmallCaps > 0);
+			unitpp::assert_true("Charis SIL smcp feature should change segment metrics",
+				dxWithoutSmallCaps != dxWithSmallCaps);
 #endif
 		}
 

Src/views/Test/TestData/Fonts/CharisSIL-5.000/OFL.txt

@@ -423,9 +423,6 @@
   <ItemGroup>
     <None Include="testViews.mak" />
     <None Include="NiceGuy.bmp" />
-    <None Include="TestData\Fonts\CharisSIL-5.000\CharisSIL-R.ttf" />
-    <None Include="TestData\Fonts\CharisSIL-5.000\OFL.txt" />
-    <None Include="TestData\Fonts\CharisSIL-5.000\README.txt" />
   </ItemGroup>
 
   <!-- Resource file -->
@@ -442,16 +439,18 @@
           WorkingDirectory="$(ProjectDir)" />
   </Target>
 
-  <ItemGroup>
-    <CharisSilTestFont Include="$(ProjectDir)TestData\Fonts\CharisSIL-5.000\CharisSIL-R.ttf" />
-    <CharisSilTestFont Include="$(ProjectDir)TestData\Fonts\CharisSIL-5.000\OFL.txt" />
-    <CharisSilTestFont Include="$(ProjectDir)TestData\Fonts\CharisSIL-5.000\README.txt" />
-  </ItemGroup>
-
+  <!-- Charis SIL test font: downloaded (not committed) by Build/PackageRestore.targets into
+       Downloads/CharisSIL; copied beside TestViews.exe so the shaping tests can load it privately.
+       The ItemGroup is inside the target so the glob resolves at execution time (after the download
+       in the downloadDlls step), and the recursive glob avoids hard-coding the pinned version. -->
   <Target Name="CopyCharisSilTestFont" AfterTargets="Build">
+    <ItemGroup>
+      <CharisSilTestFont Include="$(FwRoot)\Downloads\CharisSIL\**\CharisSIL-Regular.ttf" />
+    </ItemGroup>
     <Copy SourceFiles="@(CharisSilTestFont)"
-          DestinationFolder="$(OutDir)TestData\Fonts\CharisSIL-5.000"
-          SkipUnchangedFiles="true" />
+          DestinationFolder="$(OutDir)TestData\Fonts\CharisSIL"
+          SkipUnchangedFiles="true"
+          Condition="'@(CharisSilTestFont)' != ''" />
   </Target>
 
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />

Src/views/Test/TestData/Fonts/CharisSIL-5.000/README.txt

@@ -139,15 +139,6 @@
     <None Include="NiceGuy.bmp">
       <Filter>Resource Files</Filter>
     </None>
-    <None Include="TestData\Fonts\CharisSIL-5.000\CharisSIL-R.ttf">
-      <Filter>Resource Files</Filter>
-    </None>
-    <None Include="TestData\Fonts\CharisSIL-5.000\OFL.txt">
-      <Filter>Resource Files</Filter>
-    </None>
-    <None Include="TestData\Fonts\CharisSIL-5.000\README.txt">
-      <Filter>Resource Files</Filter>
-    </None>
     <None Include="testViews.mak" />
     <None Include="Makefile" />
   </ItemGroup>