Skip to content

Commit 51ee738

Browse files
Merge tag 'FieldWorks9.1.24'
FieldWorks 9.1.24 Change-Id: I754407f997dd7987ac319b27f681a2b7e5f9f59c
2 parents 0ee0265 + 1a564c2 commit 51ee738

345 files changed

Lines changed: 202644 additions & 2733 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Build/LibraryDevelopment.properties
88
Build/NuGet.exe
99
Build/nunit.framework.dll
1010
Build/nunit.framework.xml
11-
Build/packages.config
11+
Build/*.config
1212
Build/*.dll
1313
Build/*.pdb
1414
BuildDir/
@@ -29,8 +29,7 @@ Bin/_setLatestBuildConfig.bat
2929
Bin/_setroot.bat
3030
Lib/debug/DebugProcs.lib
3131
Lib/debug/Generic.lib
32-
Lib/debug/unit++.lib
33-
Lib/debug/unit++.pdb
32+
Lib/debug/unit++.*
3433
Lib/release/DebugProcs.lib
3534
Lib/release/Generic.lib
3635
Lib/release/unit++.lib
@@ -45,7 +44,7 @@ Src/LangInst/InstallLanguageTests/timing.txt
4544
*.user
4645
*.ncrunchsolution
4746
*.ncb
48-
*.sln
47+
FW.sln
4948
*.suo
5049
*.o
5150
*_ReSharper*

Bin/nmock/src/src/NMock.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="14.0">
2+
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="Current">
33
<PropertyGroup>
44
<ProjectType>Local</ProjectType>
55
<ProductVersion>8.0.50727</ProductVersion>

Bin/nmock/src/src/NMock/NMock.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="14.0">
1+
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="Current">
22
<PropertyGroup>
33
<ProjectType>Local</ProjectType>
44
<ProductVersion>8.0.50727</ProductVersion>

Bin/nunitforms/source/FormsTester/FormsTester.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
2+
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<PropertyGroup>
44
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
55
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>

Build/FieldWorks.proj

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Project DefaultTargets="all" InitialTargets="Setup" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0">
2+
<Project DefaultTargets="all" InitialTargets="Setup" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="Current">
33

44
<PropertyGroup>
55
<Platform Condition="'$(Platform)'==''">x64</Platform>
66
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
77
</PropertyGroup>
88

9-
<UsingTask TaskName="CatenateFiles" AssemblyFile="FwBuildTasks.dll"/>
10-
<UsingTask TaskName="Clouseau" AssemblyFile="FwBuildTasks.dll"/>
11-
<UsingTask TaskName="ComputerName" AssemblyFile="FwBuildTasks.dll"/>
12-
<UsingTask TaskName="CpuArchitecture" AssemblyFile="FwBuildTasks.dll"/>
13-
<UsingTask TaskName="DownloadFile" AssemblyFile="FwBuildTasks.dll"/>
14-
<UsingTask TaskName="DownloadFilesFromTeamCity" AssemblyFile="FwBuildTasks.dll"/>
15-
<UsingTask TaskName="ForceDelete" AssemblyFile="FwBuildTasks.dll"/>
16-
<UsingTask TaskName="GenerateFwTargets" AssemblyFile="FwBuildTasks.dll"/>
17-
<UsingTask TaskName="GenerateNUnitReports" AssemblyFile="FwBuildTasks.dll" />
18-
<UsingTask TaskName="GenerateTestCoverageReport" AssemblyFile="FwBuildTasks.dll"/>
19-
<UsingTask TaskName="LogMetadata" AssemblyFile="FwBuildTasks.dll"/>
20-
<UsingTask TaskName="Make" AssemblyFile="FwBuildTasks.dll"/>
21-
<UsingTask TaskName="Md5Checksum" AssemblyFile="FwBuildTasks.dll"/>
22-
<UsingTask TaskName="NUnit3" AssemblyFile="SIL.BuildTasks.dll"/>
23-
<UsingTask TaskName="ParentDirectory" AssemblyFile="FwBuildTasks.dll"/>
24-
<UsingTask TaskName="ParseVersionNumbers" AssemblyFile="FwBuildTasks.dll"/>
25-
<UsingTask TaskName="PathCombine" AssemblyFile="FwBuildTasks.dll"/>
26-
<UsingTask TaskName="RegFree" AssemblyFile="FwBuildTasks.dll"/>
27-
<UsingTask TaskName="RegisterForTests" AssemblyFile="FwBuildTasks.dll"/>
28-
<UsingTask TaskName="SetEnvVar" AssemblyFile="FwBuildTasks.dll"/>
29-
<UsingTask TaskName="Unitpp" AssemblyFile="FwBuildTasks.dll"/>
30-
<UsingTask TaskName="Unzip" AssemblyFile="FwBuildTasks.dll"/>
31-
<UsingTask TaskName="VerifyFilesIdentical" AssemblyFile="FwBuildTasks.dll"/>
32-
<UsingTask TaskName="WriteRegistry" AssemblyFile="FwBuildTasks.dll"/>
33-
<UsingTask TaskName="WriteTextFile" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Unix'"/>
34-
<UsingTask TaskName="WxsToWxi" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Windows_NT'"/>
35-
<UsingTask TaskName="XslTransformation" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Unix'"/>
36-
<UsingTask TaskName="Zip" AssemblyFile="FwBuildTasks.dll"/>
37-
9+
<Import Project="FwBuildTasks.targets"/>
3810
<Import Project="../packages/MSBuild.Extension.Pack.1.9.1/build/net40/MSBuild.Extension.Pack.targets" Condition="Exists('../packages/MSBuild.Extension.Pack.1.9.1/build/net40/MSBuild.Extension.Pack.targets')"/>
3911
<Import Project="LibraryDevelopment.targets" Condition="Exists('../packages/MSBuild.Extension.Pack.1.9.1/build/net40/MSBuild.Extension.Pack.targets')"/>
4012
<Import Project="GlobalInclude.properties" Condition="Exists('GlobalInclude.properties')"/>

Build/FwBuildTasks.dll

-447 KB
Binary file not shown.

Build/FwBuildTasks.targets

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
2+
<UsingTask TaskName="CatenateFiles" AssemblyFile="FwBuildTasks.dll"/>
3+
<UsingTask TaskName="Clouseau" AssemblyFile="FwBuildTasks.dll"/>
4+
<UsingTask TaskName="ComputerName" AssemblyFile="FwBuildTasks.dll"/>
5+
<UsingTask TaskName="CpuArchitecture" AssemblyFile="FwBuildTasks.dll"/>
6+
<UsingTask TaskName="DownloadFile" AssemblyFile="FwBuildTasks.dll"/>
7+
<UsingTask TaskName="DownloadFilesFromTeamCity" AssemblyFile="FwBuildTasks.dll"/>
8+
<UsingTask TaskName="ForceDelete" AssemblyFile="FwBuildTasks.dll"/>
9+
<UsingTask TaskName="GenerateFwTargets" AssemblyFile="FwBuildTasks.dll"/>
10+
<UsingTask TaskName="GenerateNUnitReports" AssemblyFile="FwBuildTasks.dll" />
11+
<UsingTask TaskName="GenerateTestCoverageReport" AssemblyFile="FwBuildTasks.dll"/>
12+
<UsingTask TaskName="GetSpecialFolderPath" AssemblyFile="FwBuildTasks.dll"/>
13+
<UsingTask TaskName="LogMetadata" AssemblyFile="FwBuildTasks.dll"/>
14+
<UsingTask TaskName="Make" AssemblyFile="FwBuildTasks.dll"/>
15+
<UsingTask TaskName="Md5Checksum" AssemblyFile="FwBuildTasks.dll"/>
16+
<UsingTask TaskName="NUnit3" AssemblyFile="SIL.BuildTasks.dll"/>
17+
<UsingTask TaskName="ParentDirectory" AssemblyFile="FwBuildTasks.dll"/>
18+
<UsingTask TaskName="ParseVersionNumbers" AssemblyFile="FwBuildTasks.dll"/>
19+
<UsingTask TaskName="PathCombine" AssemblyFile="FwBuildTasks.dll"/>
20+
<UsingTask TaskName="RegFree" AssemblyFile="FwBuildTasks.dll"/>
21+
<UsingTask TaskName="RegisterForTests" AssemblyFile="FwBuildTasks.dll"/>
22+
<UsingTask TaskName="SetEnvVar" AssemblyFile="FwBuildTasks.dll"/>
23+
<UsingTask TaskName="Substitute" AssemblyFile="FwBuildTasks.dll"/>
24+
<UsingTask TaskName="Unitpp" AssemblyFile="FwBuildTasks.dll"/>
25+
<UsingTask TaskName="Unzip" AssemblyFile="FwBuildTasks.dll"/>
26+
<UsingTask TaskName="VerifyFilesIdentical" AssemblyFile="FwBuildTasks.dll"/>
27+
<UsingTask TaskName="WriteRegistry" AssemblyFile="FwBuildTasks.dll"/>
28+
<UsingTask TaskName="Zip" AssemblyFile="FwBuildTasks.dll" />
29+
30+
<UsingTask TaskName="WriteTextFile" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Unix'" />
31+
<UsingTask TaskName="XslTransformation" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Unix'" />
32+
33+
<UsingTask TaskName="CheckAdminPrivilege" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Windows_NT'"/>
34+
<!-- REVIEW (Hasso) 2022.11: replaceable by SIL.BuildTasks.MakeWixForDirTree? -->
35+
<UsingTask TaskName="WxsToWxi" AssemblyFile="FwBuildTasks.dll" Condition="'$(OS)'=='Windows_NT'" />
36+
</Project>

Build/GlobalInclude.properties.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
<FWMAJOR>$!{FWMAJOR:0}</FWMAJOR>
66
<FWMINOR>$!{FWMINOR:0}</FWMINOR>
77
<FWREVISION>$!{FWREVISION:0}</FWREVISION>
8+
<CopyrightYear>$YEAR</CopyrightYear>
89
</PropertyGroup>
910
</Project>

Build/Installer.targets

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0">
2+
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="Current">
33
<!-- ########################################################################################################## -->
44
<!-- ### Configuration properties - Review and edit these values as needed. ### -->
55
<!-- ########################################################################################################## -->
66

77
<PropertyGroup>
88
<ApplicationName>FieldWorks Language Explorer</ApplicationName>
99
<SafeApplicationName>FieldWorks</SafeApplicationName> <!-- should not contain any spaces or illegal filename characters -->
10-
<CopyrightYear>2021</CopyrightYear>
1110
<Manufacturer>SIL International</Manufacturer>
1211
<SafeManufacturer>SIL</SafeManufacturer>
1312
</PropertyGroup>
@@ -18,16 +17,6 @@
1817
<Configuration>Release</Configuration>
1918
</PropertyGroup>
2019

21-
<!-- ########################################################################################################## -->
22-
<!-- ### PRODUCT ID GUID definition : This value must be UNIQUE for each base build. Furthermore, every ### -->
23-
<!-- ### base build must get its own unique third number (minor version) in the version number sequence. ### -->
24-
<!-- ########################################################################################################## -->
25-
26-
<!-- $(ApplicationName) 1.0.0.X ($(ApplicationName) build)-->
27-
<PropertyGroup>
28-
<ProductIdGuid>E6B62961-EA79-4E29-BA9C-6E19BB62656E</ProductIdGuid>
29-
</PropertyGroup>
30-
3120
<!-- ########################################################################################################## -->
3221
<!-- ### UPGRADE CODE GUID definition : This value must be THE SAME for every version of this product. ### -->
3322
<!-- ### Each product should have its own upgrade code. This allows installers and patches to upgrade ### -->
@@ -104,10 +93,23 @@
10493
<Error Text="The Platform property must be set on the command line to x86 or x64." Condition="'$(Platform)' == ''" />
10594
<Error Text="Installer must be run for release builds [config=$(config)]" Condition="'$(config)' != 'release'" />
10695
</Target>
96+
97+
<!--
98+
Removing files breaks the ability to patch and requires a new Base build to update.
99+
To improve our user experience we may want to delay making a new Base build so this target adds zero byte files to
100+
replace files that were removed (for instance during a library update).
101+
A base build should warn if we have 'RemovedSinceLastBase' items to help us remember to clear these out.
102+
-->
103+
<Target Name="RescuePatching">
104+
<!-- <ItemGroup>
105+
<RemovedSinceLastBase Include="$(dir-outputBase)/Example.dll" />
106+
</ItemGroup>
107+
<WriteLinesToFile File="%(RemovedSinceLastBase.FullPath)" Lines="" /> -->
108+
</Target>
107109
<!-- ########################################################################################################## -->
108110
<!-- ### Compile Targets ### -->
109111
<!-- ########################################################################################################## -->
110-
<Target Name="ProductCompile" DependsOnTargets="remakefw">
112+
<Target Name="ProductCompile" DependsOnTargets="remakefw;RescuePatching">
111113
<MSBuild Projects="$(InstallerDir)/CustomActions/CustomActions.sln" Targets="CustomActions" Properties="Configuration=Release;Platform=x86"/>
112114
</Target>
113115

@@ -172,7 +174,6 @@
172174
<DevTestArtifacts Include="$(OutputDirForConfig)\*.vrs"/> <!-- versification files from some unit tests -->
173175
<DevTestArtifacts Include="$(OutputDirForConfig)\Castle.Core.dll"/>
174176
<DevTestArtifacts Include="$(OutputDirForConfig)\Moq.dll"/>
175-
<DevTestArtifacts Include="$(OutputDirForConfig)\System.Runtime.CompilerServices.Unsafe.dll"/>
176177
<DevTestArtifacts Include="$(OutputDirForConfig)\System.Threading.Tasks.Extensions.dll"/>
177178
<FontFiles Include="$(fwrt)\DistFiles\Fonts\Raw\Quivira.otf"/>
178179
<FontFiles Include="$(DownloadsDir)\Fonts\**\*.ttf"/>
@@ -395,7 +396,7 @@
395396
Condition="!Exists('$(WixLibsDir)/vcredist_2015-19_x64.exe') And $(Platform)=='x64'"
396397
DownloadsDir="$(WixLibsDir)"/> <!-- VisualC++ 14.1 runtime -->
397398
<!-- FLEx Bridge -->
398-
<DownloadFile Address="https://build.palaso.org/guestAuth/repository/download/FLExBridgeDevelopWin32InstallerSansPublish/fw-9.1.18.tcbuildtag/FLExBridge_Offline.exe"
399+
<DownloadFile Address="https://build.palaso.org/guestAuth/repository/download/FLExBridgeDevelopWin32InstallerSansPublish/fw-9.1.22.tcbuildtag/FLExBridge_Offline.exe"
399400
Condition="!Exists('$(WixLibsDir)/FLExBridge_Offline.exe')"
400401
DownloadsDir="$(WixLibsDir)"/> <!-- TODO: always download to get the latest version -->
401402
</Target>
@@ -431,29 +432,37 @@
431432
</PropertyGroup>
432433

433434
<Target Name="BuildProductBaseMsi" DependsOnTargets="InstallerVersionNumbers">
435+
<Warning Text="RemovedSinceLastBase should be cleared out before making a new base build." Condition="'@(RemovedSinceLastBase)' != ''" />
434436
<Message Text="Building FieldWorks Base Msi for $(Arch)" Condition="'$(action)'!='test'"/>
437+
<MSBuild.ExtensionPack.Framework.Guid TaskAction="Create">
438+
<Output TaskParameter="FormattedGuidString" PropertyName="ProductIdGuid"/>
439+
</MSBuild.ExtensionPack.Framework.Guid>
440+
<Message Text="Generated GUID '$(ProductIdGuid)'"/>
435441
<PropertyGroup>
436442
<MsiFile>$(SafeApplicationName)_$(Revision).msi</MsiFile>
437443
<BaseBuildDir>$(InstallerDir)/BaseInstallerBuild</BaseBuildDir>
438444
<BaseBuildArgs>"$(ApplicationName)" $(SafeApplicationName) $(BuildVersion) $(ProductIdGuid) $(UpgradeCodeGuid) "$(AppBuildDir)/$(BinDirSuffix)" "$(AppBuildDir)/$(DataDirSuffix)" $(CopyrightYear) "$(Manufacturer)" $(SafeManufacturer) $(Arch)</BaseBuildArgs>
439445
</PropertyGroup>
440446
<!-- Suppress ICE30 because we and Encoding Converters MM both install Geckofx, resulting in an ICE warning for double ref counting -->
441447
<Exec WorkingDirectory="$(BaseBuildDir)" Command="(set SuppressICE=-sice:ICE30) &amp; buildBaseInstaller.bat $(BaseBuildArgs)" />
442-
443448
<ItemGroup>
444449
<InstallerFiles Include="$(BaseBuildDir)/**/$(SafeApplicationName)_*.exe"/>
445450
<InstallerFiles Include="$(BaseBuildDir)/**/$(SafeApplicationName)_*.msi"/>
446451
</ItemGroup>
447452
<Move SourceFiles="@(InstallerFiles)" DestinationFiles="@(InstallerFiles -> '$(InstallersBaseDir)\%(Filename)_$(Arch)%(Extension)')"/>
448453

449454
<WriteLinesToFile File="$(AppBuildDir)/version" Overwrite="true" Lines="$(BuildVersion)" />
455+
<WriteLinesToFile File="$(AppBuildDir)/ProductIdGuid" Overwrite="true" Lines="$(ProductIdGuid)" />
450456
</Target>
451457

452458
<Target Name="BuildProductPatchMsp" DependsOnTargets="InstallerVersionNumbers">
453459
<!-- TODO: work on Patch process -->
454460
<ReadLinesFromFile File="$(AppBuildMasterDir)/version">
455461
<Output TaskParameter="Lines" PropertyName="BaseVersion" />
456462
</ReadLinesFromFile>
463+
<ReadLinesFromFile File="$(AppBuildMasterDir)/ProductIdGuid">
464+
<Output TaskParameter="Lines" PropertyName="ProductIdGuid" />
465+
</ReadLinesFromFile>
457466
<PropertyGroup>
458467
<MspFile>$(SafeApplicationName)_$(BuildVersion).msp</MspFile>
459468
<PatchDir>$(InstallerDir)/CreateUpdatePatch</PatchDir>

Build/LibraryDevelopment.targets

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0">
3-
<UsingTask TaskName="MSBuild.ExtensionPack.UI.Console" AssemblyFile="../packages/MSBuild.Extension.Pack.1.9.1/tools/net40/MSBuild.ExtensionPack.dll"/>
2+
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="Current">
43
<Import Project="LibraryDevelopment.properties" Condition="Exists('LibraryDevelopment.properties')"/>
54
<Target Name="UpdateDevelopmentPropertiesFile">
65
<PropertyGroup>
@@ -25,7 +24,7 @@
2524
<!-- Using .temp file since it seemed xbuild was sometimes loading the .properties file while it was being composed. -->
2625
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Overwrite="true" Lines="&lt;?xml version=&quot;1.0&quot; encoding=&quot;utf-8&quot;?&gt;" />
2726
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;!-- This file is generated by the (Update|Write)DevelopmentPropertiesFile task, but it is safe to hand edit. --&gt;" />
28-
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;Project xmlns=&quot;http://schemas.microsoft.com/developer/msbuild/2003&quot; ToolsVersion=&quot;4.0&quot;&gt;" />
27+
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;Project xmlns=&quot;http://schemas.microsoft.com/developer/msbuild/2003&quot; ToolsVersion=&quot;Current&quot;&gt;" />
2928
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;PropertyGroup&gt;" />
3029
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;UseLocalLibraries&gt;$(UseLocalLibraries)&lt;/UseLocalLibraries&gt;" />
3130
<WriteLinesToFile File="LibraryDevelopment.properties.temp" Lines="&lt;PalasoArtifactsDir Condition=&quot;'%24(UseLocalLibraries)'=='Y'&quot;&gt;$(PalasoArtifactsDir)&lt;/PalasoArtifactsDir&gt;" />

0 commit comments

Comments
 (0)