Skip to content

Commit 7908ff0

Browse files
Fix LT-22509: Newtonsoft.Json Method not found error
- Newtonsoft.Json doesn't change assembly versions on minor version bumps. 13.0.4 added a method and we started using it in libpalaso. If a version less than that is installed in the GAC our local version would not be loaded. This patch enforces using our local copy by our application. Change-Id: I9b7cdfbe792fda13b3dcc570c2c5dc8d19e6d596
1 parent 2907321 commit 7908ff0

4 files changed

Lines changed: 24 additions & 0 deletions

File tree

Src/Common/FieldWorks/App.config

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@ Only entries that auto-gen cannot produce are kept below.
2323
<assemblyIdentity name="SIL.Core.Desktop" publicKeyToken="cab3c8c5232dfcf2" culture="neutral" />
2424
<codeBase version="0.0.0.0" href="SIL.Core.Desktop.dll" />
2525
</dependentAssembly>
26+
<!-- Newtonsoft.Json 13.x: assembly version stays 13.0.0.0 across NuGet patches; codeBase loads the private DLL
27+
when a same-identity copy exists in the GAC. Auto-gen does not emit codeBase. -->
28+
<dependentAssembly>
29+
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
30+
<codeBase version="13.0.0.0" href="Newtonsoft.Json.dll" />
31+
</dependentAssembly>
2632
<!-- Chorus 6.0.0 references L10NSharp 9.0.0; redirect to 10.0.0.
2733
Remove when Chorus is updated to reference L10NSharp 10. -->
2834
<dependentAssembly>

Src/GenerateHCConfig/App.config

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
<runtime>
44
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
55
<!-- Binding redirects are auto-generated at build time. -->
6+
<!-- Newtonsoft.Json 13.x: assembly version stays 13.0.0.0 across NuGet patches; codeBase loads the private DLL
7+
when a same-identity copy exists in the GAC. Auto-gen does not emit codeBase. -->
8+
<dependentAssembly>
9+
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
10+
<codeBase version="13.0.0.0" href="Newtonsoft.Json.dll" />
11+
</dependentAssembly>
612
</assemblyBinding>
713
</runtime>
814
</configuration>

Src/Paratext8Plugin/ParaText8PluginTests/App.config

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
<runtime>
44
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
55
<!-- Binding redirects are auto-generated at build time. -->
6+
<!-- Newtonsoft.Json 13.x: assembly version stays 13.0.0.0 across NuGet patches; codeBase loads the private DLL
7+
when a same-identity copy exists in the GAC. Auto-gen does not emit codeBase. -->
8+
<dependentAssembly>
9+
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
10+
<codeBase version="13.0.0.0" href="Newtonsoft.Json.dll" />
11+
</dependentAssembly>
612
</assemblyBinding>
713
</runtime>
814
</configuration>

Src/UnicodeCharEditor/App.config

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
<runtime>
44
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
55
<!-- Binding redirects are auto-generated at build time. -->
6+
<!-- Newtonsoft.Json 13.x: assembly version stays 13.0.0.0 across NuGet patches; codeBase loads the private DLL
7+
when a same-identity copy exists in the GAC. Auto-gen does not emit codeBase. -->
8+
<dependentAssembly>
9+
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
10+
<codeBase version="13.0.0.0" href="Newtonsoft.Json.dll" />
11+
</dependentAssembly>
612
</assemblyBinding>
713
</runtime>
814
</configuration>

0 commit comments

Comments
 (0)