LT-22306: Fix Startup Crash on Clean Machine (#507)

Prompt the user for update preferences after initializing the
l10n manager. The l10n manager must be initialized before looking
up strings to prevent language IDs from being mapped incorrectly
(see https://issues.bloomlibrary.org/youtrack/issue/BL-13245).

The prompt remains as early in startup as possible so that the
user can choose before any update checks are initiated.

Author: papeh

Src/Common/FieldWorks/FieldWorks.cs

@@ -185,18 +185,6 @@ static int Main(string[] rgArgs)
 				s_appSettings.DeleteCorruptedSettingsFilesIfPresent();
 				s_appSettings.UpgradeIfNecessary();
 
-				if (s_appSettings.Update == null && Platform.IsWindows)
-				{
-					s_appSettings.Update = new UpdateSettings
-					{
-						Behavior = DialogResult.Yes == FlexibleMessageBox.Show(
-								Properties.Resources.AutomaticUpdatesMessage, Properties.Resources.AutomaticUpdatesCaption, MessageBoxButtons.YesNo,
-								options: FlexibleMessageBoxOptions.AlwaysOnTop)
-							? UpdateSettings.Behaviors.Download
-							: UpdateSettings.Behaviors.DoNotCheck
-					};
-				}
-
 				var reportingSettings = s_appSettings.Reporting;
 				if (reportingSettings == null)
 				{
@@ -233,6 +221,19 @@ static int Main(string[] rgArgs)
 					SetupErrorReportInformation();
 					InitializeLocalizationManager();
 
+					// Initialize update settings for users who don't have them. After InitializeLocalizationManager because it displays strings (LT-22306)
+					if (s_appSettings.Update == null && Platform.IsWindows)
+					{
+						s_appSettings.Update = new UpdateSettings
+						{
+							Behavior = DialogResult.Yes == FlexibleMessageBox.Show(
+									Properties.Resources.AutomaticUpdatesMessage, Properties.Resources.AutomaticUpdatesCaption, MessageBoxButtons.YesNo,
+									options: FlexibleMessageBoxOptions.AlwaysOnTop)
+								? UpdateSettings.Behaviors.Download
+								: UpdateSettings.Behaviors.DoNotCheck
+						};
+					}
+
 					// Invoke does nothing directly, but causes BroadcastEventWindow to be initialized
 					// on this thread to prevent race conditions on shutdown.See TE-975
 					// See http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=911603&SiteID=1