Skip to content

Commit d82df8f

Browse files
authored
Include all frameworks in local LCM, Palaso & Chorus (#481)
One of the LCM target frameworks is netstandard2.0. To build a local LCM that uses a local Palaso, LCM needs the netstandard2.0 framework to be in the palaso nupkg. By removing the TargetFrameworks parameter from the ‘dotnet pack’ command the nuget packages will contain all the frameworks specified in the .csproj files.
1 parent 617c129 commit d82df8f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Build/buildLocalLibraries.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function delete_and_pack_liblcm {
4646
(cd "$liblcm_dir/artifacts" && rm *nupkg)
4747

4848
echo "Running 'dotnet pack' in the liblcm directory: $liblcm_dir"
49-
pack_output=$(cd "$liblcm_dir" && dotnet pack -c Debug -p:TargetFrameworks=$liblcm_net_ver)
49+
pack_output=$(cd "$liblcm_dir" && dotnet pack -c Debug)
5050

5151
# Extract version number using regex
5252
if [[ $pack_output =~ $version_regex ]]; then
@@ -91,7 +91,7 @@ function delete_and_pack_chorus {
9191
(cd "$chorus_dir/output" && rm *nupkg)
9292

9393
echo "Running 'dotnet pack' in the chorus directory: $chorus_dir"
94-
pack_output=$(cd "$chorus_dir" && dotnet pack -c Debug -p:TargetFrameworks=$chorus_net_ver)
94+
pack_output=$(cd "$chorus_dir" && dotnet pack -c Debug)
9595

9696
# Extract version number using regex
9797
if [[ $pack_output =~ $version_regex ]]; then
@@ -136,7 +136,7 @@ function delete_and_pack_libpalaso {
136136
(cd "$libpalaso_dir/output" && rm *nupkg)
137137

138138
echo "Running 'dotnet pack' in the libpalaso directory: $libpalaso_dir"
139-
pack_output=$(cd "$libpalaso_dir" && dotnet pack -c Debug -p:TargetFrameworks=$libpalaso_net_ver)
139+
pack_output=$(cd "$libpalaso_dir" && dotnet pack -c Debug)
140140

141141
# Extract version number using regex
142142
if [[ $pack_output =~ $version_regex ]]; then

0 commit comments

Comments
 (0)