LT-21766: Fix Reversal Sort Order in Webonary#362
Closed
mark-sil wants to merge 1 commit into
Closed
Conversation
In some situations the CurrentReversalWsId is not correct. Now we first try to get a ws from the SubComparer (if it is a WritingSystemComparer). This looks like the same place that the Sorter gets the ws. Change-Id: I93c03dd2eb24bad4fa806e3015f01860261945ab
jtmaxwell3
approved these changes
Jun 3, 2025
jtmaxwell3
left a comment
jtmaxwell3
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some situations the CurrentReversalWsId is not correct. Now we first try to get a ws from the SubComparer (if it is a WritingSystemComparer). This looks like the same place that the Sorter gets the ws.
This change is