Skip to content

Fix LT-5408: Show which parses are valid in chooser #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 9 commits into from
Jun 12, 2025
Merged

Fix LT-5408: Show which parses are valid in chooser #364

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4802e87
Add highlighting for parser-approved analyses
jtmaxwell3 Mar 17, 2025
e332afd
Add GetAnalysisColor
jtmaxwell3 Apr 1, 2025
a5c63af
Change to use check marks and red Xs
jtmaxwell3 Apr 7, 2025
24f6235
Add AddOpinion
jtmaxwell3 Apr 8, 2025
2ff5b68
Add SetGuessColor. Make double approved analyses be green
jtmaxwell3 May 5, 2025
b81cebb
Remove double coloring and add space
jtmaxwell3 May 29, 2025
88ef6f9
Fix unit test failure
jtmaxwell3 Jun 9, 2025
d7eac5b
Remove unnecessary changes
jtmaxwell3 Jun 9, 2025
e578e22
Merge branch 'release/9.3' into LT-5408
jtmaxwell3 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions Src/LexText/Interlinear/ChooseAnalysisHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,17 @@ internal static ITsString MakeAnalysisStringRep(IWfiAnalysis wa, LcmCache fdoCac
lim = -1;
increment = -1;
}

if (wa?.Cache?.LanguageProject != null)
{
Opinions uao = wa.GetAgentOpinion(wa.Cache.LangProject.DefaultUserAgent);
Opinions pao = wa.GetAgentOpinion(wa.Cache.LangProject.DefaultParserAgent);
AddOpinion(tsb, uao, InterlinVc.ApprovedGuessColor);
AddOpinion(tsb, pao, InterlinVc.MachineGuessColor);
tsb.Replace(tsb.Length, tsb.Length, " ", null);
tsb.SetProperties(tsb.Length - 1, tsb.Length, formTextProperties);
}

for (int i = start; i != lim; i += increment)
{
var mb = wa.MorphBundlesOS[i];
Expand Down Expand Up @@ -457,6 +468,27 @@ internal static ITsString MakeAnalysisStringRep(IWfiAnalysis wa, LcmCache fdoCac
return tsb.GetString();
}

private static void AddOpinion(ITsStrBldr tsb, Opinions opinion, int backColor)
{
int foreColor = (int)CmObjectUi.RGB(Color.Black);
if (opinion == Opinions.approves)
tsb.Replace(tsb.Length, tsb.Length, "\u2714", null); // bold check mark
else if (opinion == Opinions.noopinion)
{
// Use same foreground and background color to create a blank of the same width as a check mark.
tsb.Replace(tsb.Length, tsb.Length, "\u2714", null);
foreColor = backColor;
}
else if (opinion == Opinions.disapproves)
{
tsb.Replace(tsb.Length, tsb.Length, "X", null);
foreColor = (int)CmObjectUi.RGB(Color.Red);
}
tsb.SetStrPropValue(tsb.Length - 1, tsb.Length, (int)FwTextPropType.ktptFontFamily, "Segoe UI Symbol");
tsb.SetIntPropValues(tsb.Length - 1, tsb.Length, (int)FwTextPropType.ktptForeColor, (int)FwTextPropVar.ktpvDefault, foreColor);
tsb.SetIntPropValues(tsb.Length - 1, tsb.Length, (int)FwTextPropType.ktptBackColor, (int)FwTextPropVar.ktpvDefault, backColor);
}

/// <summary>
///
/// </summary>
Expand Down
Loading