LT-21960: Fix COM problem with VwPropertyStore#377
Conversation
Instead of using COM we added a wrapper class that uses DllImport to create and call methods on the VwPropertyStore object. Change-Id: I8681ad9140a3b5a887b1ba672dae9b58dab55a75
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Src/views/Views.idh line 3452 at r1 (raw file):
// those currently in the store. In particular, if the current VwPropertyStore has just // been created and not changed, the properties will be the system default properties. [propget] HRESULT TextProps([out,retval] ITsTextProps ** ppttp);
How did you obsolete this definition? (I see replacements for the others but this one isn't clear to me)
mark-sil
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Src/views/Views.idh line 3452 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
How did you obsolete this definition? (I see replacements for the others but this one isn't clear to me)
This one wasn't being used so I thought it would be ok to remove it along with the others. Should I add it back?
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Instead of using COM we added a wrapper class that uses DllImport to create and call methods on the VwPropertyStore object.
Change-Id: I8681ad9140a3b5a887b1ba672dae9b58dab55a75
This change is