Skip to content

LT-21960: Fix COM problem with VwPropertyStore#377

Merged
jasonleenaylor merged 2 commits into
release/9.3from
LT-21960
Jun 26, 2025
Merged

LT-21960: Fix COM problem with VwPropertyStore#377
jasonleenaylor merged 2 commits into
release/9.3from
LT-21960

Conversation

@mark-sil

@mark-sil mark-sil commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Instead of using COM we added a wrapper class that uses DllImport to create and call methods on the VwPropertyStore object.

Change-Id: I8681ad9140a3b5a887b1ba672dae9b58dab55a75


This change is Reviewable

Instead of using COM we added a wrapper class that uses
DllImport to create and call methods on the VwPropertyStore
object.

Change-Id: I8681ad9140a3b5a887b1ba672dae9b58dab55a75

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)


Src/views/Views.idh line 3452 at r1 (raw file):

		// those currently in the store. In particular, if the current VwPropertyStore has just
		// been created and not changed, the properties will be the system default properties.
		[propget] HRESULT TextProps([out,retval] ITsTextProps ** ppttp);

How did you obsolete this definition? (I see replacements for the others but this one isn't clear to me)

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)


Src/views/Views.idh line 3452 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

How did you obsolete this definition? (I see replacements for the others but this one isn't clear to me)

This one wasn't being used so I thought it would be ok to remove it along with the others. Should I add it back?

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

@jasonleenaylor jasonleenaylor merged commit 86e8b12 into release/9.3 Jun 26, 2025
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21960 branch June 26, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants