LT-22165 HC does not handle multiple compounds in a row#394
Merged
Conversation
Change-Id: I7970523b22e368f39dacd7caf54b08e01ff0c9f6
Change-Id: If2260d196dbb92d132fb770864901fb5c148ea88
Change-Id: Ia7cd5d510af61362aa6d3766632b3549967a6673
Change-Id: Ib7a3f3539de89c96bf4b23e3722f8e5aa1e3dd23
Contributor
|
As an outsider I don't know why MaxRoots is between 2 and 10. Is this a decision that should be commented in this PR or is this just understood by parser domain experts? |
Change-Id: Idba35759cc5a6de32a13955f292956b324036cc1
Collaborator
Author
|
It should be understood by domain experts, but I added some comments anyway and pushed them. |
Change-Id: Ic6892746575b5fe3e79fc6b19da5dff97912bca9
Change-Id: I185b115f7f45a588f7a22e2740401dd9aced91fd
jasonleenaylor
approved these changes
Jul 22, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution adds two items to the Hermit Crab parser parameters:
When the button is clicked, it brings up a dialog showing all compound rules (whether active or not) and the number of times each can be applied. The user can choose to set the number for a given rule to any digit from 1 to 9.
When producing the input for HC, the maximum number of applications allowed for each rule is set to the remembered value. When a rule has more than one application, we use the rule's GUID in the parser parameters to record the number of applications allowed.
This change is