Skip to content

LT-22165 HC does not handle multiple compounds in a row#394

Merged
AndyBlack merged 8 commits into
release/9.3from
LT22165
Jul 22, 2025
Merged

LT-22165 HC does not handle multiple compounds in a row#394
AndyBlack merged 8 commits into
release/9.3from
LT22165

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

This solution adds two items to the Hermit Crab parser parameters:

  1. Adds a MaxRoots parameter to the HC section
  2. Adds a button "Set max applications of HC Compound rules"
    When the button is clicked, it brings up a dialog showing all compound rules (whether active or not) and the number of times each can be applied. The user can choose to set the number for a given rule to any digit from 1 to 9.

When producing the input for HC, the maximum number of applications allowed for each rule is set to the remembered value. When a rule has more than one application, we use the rule's GUID in the parser parameters to record the number of applications allowed.


This change is Reviewable

Change-Id: I7970523b22e368f39dacd7caf54b08e01ff0c9f6
Change-Id: If2260d196dbb92d132fb770864901fb5c148ea88
Change-Id: Ia7cd5d510af61362aa6d3766632b3549967a6673
Change-Id: Ib7a3f3539de89c96bf4b23e3722f8e5aa1e3dd23
@jasonleenaylor

Copy link
Copy Markdown
Contributor

Src/LexText/ParserCore/HCParser.cs line 146 at r1 (raw file):

			int delReapps = 0;
			int maxStemCount = 2;

As an outsider I don't know why MaxRoots is between 2 and 10. Is this a decision that should be commented in this PR or is this just understood by parser domain experts?

Change-Id: Idba35759cc5a6de32a13955f292956b324036cc1
@AndyBlack

AndyBlack commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator Author

It should be understood by domain experts, but I added some comments anyway and pushed them.
Ah, I also needed to change it to allow for MaxRoots to be 1.

Change-Id: Ic6892746575b5fe3e79fc6b19da5dff97912bca9
Change-Id: I185b115f7f45a588f7a22e2740401dd9aced91fd

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

@AndyBlack AndyBlack merged commit 43f6e34 into release/9.3 Jul 22, 2025
4 of 5 checks passed
@AndyBlack AndyBlack deleted the LT22165 branch July 22, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants