Skip to content

Fix LT-22220: Copy Nuget System.Buffers post build (Lib folder) #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonleenaylor merged 2 commits into from
Jul 24, 2025
Merged

Fix LT-22220: Copy Nuget System.Buffers post build (Lib folder) #410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2affe
Fix LT-22220: Copy Nuget System.Buffers post build
jasonleenaylor Jul 24, 2025
518a9a3
Merge branch 'release/9.3' into LT-22220
jasonleenaylor Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Lib/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
<Project>
<!-- .Net Framework projects which reference netstandard2.0 end up copying a bad version of System.ValueTuple -->
<!-- .Net Framework projects which reference netstandard2.0 end up copying a bad version of some System libraries -->
<!-- Rather than try to fix it here and there we'll just go nuclear and copy the right one in after every project -->
<Target Name="CopyCorrectSystemValueTuple" AfterTargets="Build">
<Target Name="CopyCorrectSystemAssemblies" AfterTargets="Build">
<ItemGroup>
<TupleAssembly Include="$(MSBuildThisFileDirectory)/../packages/System.ValueTuple.4.5.0/lib/net461/System.ValueTuple.dll" />
<SystemAssembly Include="$(MSBuildThisFileDirectory)/../packages/System.ValueTuple.4.5.0/lib/net461/System.ValueTuple.dll" />
<SystemAssembly Include="$(MSBuildThisFileDirectory)/../Downloads/System.Buffers.dll" />
</ItemGroup>
<Message Text="Copying @(TupleAssembly) to $(OutDir)" />
<Message Text="Copying @(SystemAssembly) to $(OutDir)" />
<Error
Text="System.ValueTuple not found in the packages folder."
Condition="!Exists('$(MSBuildThisFileDirectory)/../packages/System.ValueTuple.4.5.0/lib/net461/System.ValueTuple.dll')" />
<Copy SourceFiles="@(TupleAssembly)" DestinationFolder="$(OutDir)" />
<Error
Text="System.Buffers not found in the downloads folder."
Condition="!Exists('$(MSBuildThisFileDirectory)/../Downloads/System.Buffers.dll')" />
<Copy SourceFiles="@(SystemAssembly)" DestinationFolder="$(OutDir)" SkipUnchangedFiles="true" />
</Target>
</Project>
Loading