Fix LT-22189: FW9.2 does much worse with data entry than 9.1#411
Merged
Conversation
Contributor
|
This is safe if DefaultCreateNewUiObject can only be called from 'CreateNewUiObject', did you verify that? |
Collaborator
Author
|
Yes. The other place DefaultCreateNewUiObject is called from doesn't have a mediator, so moving the try .. catch up doesn't change anything. |
jasonleenaylor
approved these changes
Jul 24, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix https://jira.sil.org/browse/LT-22189, I had to revert #182 and also move a try ... catch ... finally wrapper from DefaultCreateNewUiObject up into CreateNewUiObject so that it would apply to non-default objects such as Pronunciation.
This change is