Skip to content

Fix LT-22189: FW9.2 does much worse with data entry than 9.1#411

Merged
jtmaxwell3 merged 4 commits into
release/9.3from
LT-22189
Jul 24, 2025
Merged

Fix LT-22189: FW9.2 does much worse with data entry than 9.1#411
jtmaxwell3 merged 4 commits into
release/9.3from
LT-22189

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

To fix https://jira.sil.org/browse/LT-22189, I had to revert #182 and also move a try ... catch ... finally wrapper from DefaultCreateNewUiObject up into CreateNewUiObject so that it would apply to non-default objects such as Pronunciation.


This change is Reviewable

@jasonleenaylor

Copy link
Copy Markdown
Contributor

Src/FdoUi/FdoUiCore.cs line 420 at r1 (raw file):

		{
			CmObjectUi newUiObj = null;
			try

This is safe if DefaultCreateNewUiObject can only be called from 'CreateNewUiObject', did you verify that?

@jtmaxwell3

Copy link
Copy Markdown
Collaborator Author

Yes. The other place DefaultCreateNewUiObject is called from doesn't have a mediator, so moving the try .. catch up doesn't change anything.

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) July 24, 2025 18:25
@jtmaxwell3 jtmaxwell3 merged commit bcaf7c8 into release/9.3 Jul 24, 2025
5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22189 branch July 24, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants