Skip to content

Fix LT-22193: Change in Yellow Bar behavior in Interlinear Texts#413

Merged
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22193
Jul 25, 2025
Merged

Fix LT-22193: Change in Yellow Bar behavior in Interlinear Texts#413
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22193

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22193.


This change is Reviewable

@jasonleenaylor

Copy link
Copy Markdown
Contributor

Src/LexText/Interlinear/FocusBoxController.cs line 132 at r1 (raw file):

			//if this sandbox is presenting a wordform with multiple possible analyses then set the
			//bg color indicator
			if (selected.Analysis.Analysis == null && selected.Analysis.Wordform != null &&

Do you know what changed to invalidate this condition? I don't think this line was part of any recent changes.

@jtmaxwell3

Copy link
Copy Markdown
Collaborator Author

I don't know for sure what changed, though I vaguely remember a problem with initialization that I may have fixed incorrectly.

@jtmaxwell3

Copy link
Copy Markdown
Collaborator Author

I looked back in the code, and there weren't any changes in this area. It may be that this bug has been here for a while, but that nobody noticed it.

@jtmaxwell3

Copy link
Copy Markdown
Collaborator Author

I found where I broke it: 53b16bd.

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @jtmaxwell3)

@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) July 25, 2025 15:55
@jtmaxwell3 jtmaxwell3 merged commit b6fdac4 into release/9.3 Jul 25, 2025
4 of 5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22193 branch July 25, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants