Skip to content

Fix LT-22145: Make non-multilingual string slices default to 1st analysis #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonleenaylor merged 3 commits into from
Jul 25, 2025
Merged

Fix LT-22145: Make non-multilingual string slices default to 1st analysis #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17ac1f7
Fix LT-22145: Make non-multilingual string slice default to 1st analysis
jasonleenaylor Jul 25, 2025
5daf974
Merge branch 'release/9.3' into LT-222145
jtmaxwell3 Jul 25, 2025
5906f49
Merge branch 'release/9.3' into LT-222145
jtmaxwell3 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Src/Common/Controls/DetailControls/StringSlice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,10 @@ public override void Display(IVwEnv vwenv, int hvo, int frag)
#endregion // View Constructors

#region RootSite implementation
/// <summary>
/// This is a RootSiteControl that displays a non-multilingual string slice
/// Data entry should always default to the DefaultAnalWs writing system according to LT-22145
/// </summary>
class StringSliceView : RootSiteControl, INotifyControlInCurrentSlice
{
ICmObject m_obj;
Expand Down Expand Up @@ -421,6 +425,14 @@ public int DefaultWs
(m_vc as StringSliceVc).DefaultWs = value;
}
}

public override int WsPending
{
// Ignore requests to set pending writing system, this slice always deals with the DefaultAnalWs.
// ReSharper disable once ValueParameterNotUsed
set { }
get => Cache != null ? Cache.DefaultAnalWs : -1;
}
#region IDisposable override

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Src/Common/SimpleRootSite/SimpleRootSite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1692,7 +1692,7 @@ public virtual Rectangle AdjustedClientRectangle
/// informtion away and reset the keyboard).
/// </remarks>
/// -----------------------------------------------------------------------------------
public int WsPending
public virtual int WsPending
{
get
{
Expand Down
Loading