LT-21960: Fix export issues when there is filtering#417
Merged
Conversation
When there is filtering applied to the entries, then only the currently viewed entries would export correctly. (If the main dictionary was being viewed, then the filtered reversal entries would not export correctly. If a reversal was currently being viewed, then a filtered main dictionary would not export correctly.) The same problem existed for both Word and Xhtml exports. To resolve the problem with filtered entries we now do the collection of entries on the main thread. Change-Id: I918442b2225310e70cb9f0e2903c52ae78281a9b
jasonleenaylor
approved these changes
Jul 30, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is filtering applied to the entries, then only the currently viewed entries would export correctly. (If the main dictionary was being viewed, then the filtered reversal entries would not export correctly. If a reversal was currently being viewed, then a filtered main dictionary would not export correctly.)
The same problem existed for both Word and Xhtml exports. To resolve the problem with filtered entries we now do the collection of entries on the main thread.
This change is