Skip to content

Fix LT-22239: Missing updates in Parsing Development Mode#422

Merged
jasonleenaylor merged 2 commits into
release/9.3from
LT-22239
Aug 1, 2025
Merged

Fix LT-22239: Missing updates in Parsing Development Mode#422
jasonleenaylor merged 2 commits into
release/9.3from
LT-22239

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22239. I identified some problems with missing updates while looking at https://jira.sil.org/browse/LT-22236. I needed to make the following changes to the code:

  • Trigger redisplay of glosses when in Parsing Development Mode (because of their border colors). This required passing in an InterlineDocRootSiteBase to access IsParsingDevMode().
  • Apply CheckUpdateWordform to both kflidEvaluations and kflidAnalyses to get upper case words right in both cases.
  • Change m_analysesWithNewGuesses to m_wordformsWithNewGuesses for consistency (m_analysesWithNewGuesses was a mixture of analyses and wordforms before, which led to some updates being missed).
  • Send "RefreshInterlin" message after running the Remove Parser-approved analyses utility to refresh the interlinear display.

This change is Reviewable

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I didn't run it and verify but :lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor enabled auto-merge (squash) August 1, 2025 22:00
@jasonleenaylor jasonleenaylor merged commit 7f1d648 into release/9.3 Aug 1, 2025
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-22239 branch August 1, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants