Skip to content

LT-22137#425

Merged
AndyBlack merged 10 commits into
release/9.3from
LT22137
Aug 13, 2025
Merged

LT-22137#425
AndyBlack merged 10 commits into
release/9.3from
LT22137

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Aug 2, 2025 •
edited by jasonleenaylor
Loading

Copy link
Copy Markdown
Collaborator

This adds exception features to compound rules and covers LT-22137, LT-22138, LT-22139, LT-22140, LT-22141, and LT-22144.

It needs to be included before LT-22156 can be completed because LT-22156 also has a change in Hermit Crab and the new changes won't compile until the changes included here for LT-22140 are done.

It needs the latest version of Hermit Crab with C# code changes.
There are XSLT changes for formatting the HC trace, the XAmple word grammar and the word grammar debugger, and for generating the morph sketch.
There are UI changes for adding exception features to compound rules.

This change is Reviewable

AndyBlack added 8 commits May 12, 2025 09:12
@AndyBlack
Fix for LT-10373
7505c84 
Change-Id: Id5176780bd7b0b77a91badf4af5c3dcd7bec1467
@AndyBlack
LT-22138: Add UI for exception "features" in compound rules
24abab2 
Change-Id: I3fde502e57a604f65cbe440f6529e67275cb16c6
@AndyBlack
LT-22139 Add exception "features" for compound rules for XAmple
afc1f37 
Change-Id: Ib246809bbaaa4940b56d15a63d5221a878ccdce8
@AndyBlack
LT-22144 Prod restricts in compounds in XAmple word grammar debugger
b7efc4e 
Change-Id: I7887192686a64ecfd5f6b3550417114e473f214a
@AndyBlack
LT-22138: make inactive prod restricts show in grey
04309e1 
Change-Id: I170dcb5b338b0d09d0984525a91a80c8ffbea3b5
@AndyBlack
LT-22141: add prod restricts in compounds to morph sketch
e21f8a7 
Change-Id: I10ba91423d1540a8cd1ff2204a86bd3939568323
@AndyBlack
LT-22140 add prod restricts to Hermit Crab
3dc2541 
Change-Id: I145dc82cbe9646f3579fa2477f25488aac561c53
@AndyBlack
Merge branch 'release/9.3' into LT22137
ab2ba82
@jasonleenaylor

jasonleenaylor commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Src/LexText/ParserCore/FwXmlTraceManager.cs line 17 at r1 (raw file):

using System.Text;
using SIL.Machine.Rules;
using SIL.Core.ClearShare;

Is ClearShare really being used here?

@AndyBlack

AndyBlack commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

Good catch. There were some other unnecessary using statements, too. I removed them.

@jasonleenaylor

jasonleenaylor commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Src/LexText/ParserCore/ParserCoreTests/M3ToXAmpleTransformerTestsDataFiles/CompundRulesWithExceptionFeaturesWordGrammar.txt line 2 at r1 (raw file):

| DO NOT EDIT THIS FILE DIRECTLY!

Do we need this file committed into the folder? I don't think I saw where the contents were validated (and it would be fragile if it was)

@AndyBlack

AndyBlack commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

This is yet another instance of a test output file for what the XAmple transforms produce as input to XAmple. See
Src\LexText\ParserCore\ParserCoreTests\M3ToXAmpleTransformerTestsDataFiles for many other such test files for various cases.
Or did I misunderstand what you are asking?

@AndyBlack

AndyBlack commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

That file is used in Src/LexText/ParserCore/ParserCoreTests/M3ToXAmpleTransformerTests.cs as are the other test files. And the changes are included in the LT-22139 commit. Does this help?

jasonleenaylor
jasonleenaylor approved these changes Aug 13, 2025
View reviewed changes

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 29 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

@AndyBlack AndyBlack merged commit 5b9e474 into release/9.3 Aug 13, 2025
5 checks passed
@AndyBlack AndyBlack deleted the LT22137 branch August 13, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyBlack @jasonleenaylor