Skip to content

Fix LT-22204: Phonological rule output not written correctly#429

Merged
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22204
Aug 5, 2025
Merged

Fix LT-22204: Phonological rule output not written correctly#429
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22204

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22204.


This change is Reviewable

@jasonleenaylor

Copy link
Copy Markdown
Contributor

Src/LexText/ParserCore/FwXmlTraceManager.cs line 410 at r1 (raw file):

		private static string ToBracketedString(IEnumerable<ShapeNode> nodes, CharacterDefinitionTable table)
		{
			// This should be in defined as Shape.ToBrackedString in HermitCrab.

I think you meant Shape.ToBracketedString here

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) August 5, 2025 16:22
@jtmaxwell3 jtmaxwell3 merged commit 0dabd60 into release/9.3 Aug 5, 2025
4 of 5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22204 branch August 5, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants