LT-22124: Fix Sense homographs in Lexical Relations

[mark-sil]

When trying to get the HeadWordRef for a LexSense, get the value from the associated LexEntry. The LexEntry has a custom field that adjusts the HeadWordRef based on the decorator, the LexSense does not.

---

This change is 

[mark-sil]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions

---

-- commits line 8 at r1:
Is the second sentence in this comment correct? If it is correct, then is it ok to get the HeadWordRef from the associated LexEntry when we have a LexSense? If it is not ok, then should I add a custom field for the LexSense that is created and maintained similar to what is done for the LexEntry?

---

Src/xWorks/ConfiguredLcmGenerator.cs line 705 at r1 (raw file):

				{
					// Get the HeadWordRef from the LexEntry.
					if (customFieldName == "HeadWordRef")

Instead of specifically checking for "HeadWordRef", is there something more general that I should be checking?

[jasonleenaylor]

Sorry that it took me all day.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mark-sil)

---

-- commits line 8 at r1:

Previously, mark-sil (Mark Kidder) wrote…

Is the second sentence in this comment correct? If it is correct, then is it ok to get the HeadWordRef from the associated LexEntry when we have a LexSense? If it is not ok, then should I add a custom field for the LexSense that is created and maintained similar to what is done for the LexEntry?

The comment isn't quite correct, because this isn't actually a custom field. The customFieldName in GetPropValueForModelField should be renamed to fieldName (this used to be used only for custom fields).

I think we probably should be handling the HeadWordRef for senses somewhere else.

---

Src/xWorks/ConfiguredLcmGenerator.cs line 705 at r1 (raw file):

Previously, mark-sil (Mark Kidder) wrote…

Instead of specifically checking for "HeadWordRef", is there something more general that I should be checking?

After much head scratching I don't think this is the correct solution. It seems that there should be a Sense method which uses the decorator to get the information...and it feels like it should already exist but it just isn't being used by this export yet.