Skip to content

LT-22124: Fix Sense homographs in Lexical Relations#431

Closed
mark-sil wants to merge 1 commit into
release/9.3from
LT-22124
Closed

LT-22124: Fix Sense homographs in Lexical Relations#431
mark-sil wants to merge 1 commit into
release/9.3from
LT-22124

Conversation

@mark-sil

@mark-sil mark-sil commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

When trying to get the HeadWordRef for a LexSense, get the value from the associated LexEntry. The LexEntry has a custom field that adjusts the HeadWordRef based on the decorator, the LexSense does not.


This change is Reviewable

When trying to get the HeadWordRef for a LexSense, get the
value from the associated LexEntry. The LexEntry has a custom
field that adjusts the HeadWordRef based on the decorator, the
LexSense does not.

Change-Id: Ib420edbd6a08ac5b02f074da2ec883756c66f8c2

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions


-- commits line 8 at r1:
Is the second sentence in this comment correct? If it is correct, then is it ok to get the HeadWordRef from the associated LexEntry when we have a LexSense? If it is not ok, then should I add a custom field for the LexSense that is created and maintained similar to what is done for the LexEntry?


Src/xWorks/ConfiguredLcmGenerator.cs line 705 at r1 (raw file):

				{
					// Get the HeadWordRef from the LexEntry.
					if (customFieldName == "HeadWordRef")

Instead of specifically checking for "HeadWordRef", is there something more general that I should be checking?

@mark-sil mark-sil requested a review from jasonleenaylor August 6, 2025 15:56

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it took me all day.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mark-sil)


-- commits line 8 at r1:

Previously, mark-sil (Mark Kidder) wrote…

Is the second sentence in this comment correct? If it is correct, then is it ok to get the HeadWordRef from the associated LexEntry when we have a LexSense? If it is not ok, then should I add a custom field for the LexSense that is created and maintained similar to what is done for the LexEntry?

The comment isn't quite correct, because this isn't actually a custom field. The customFieldName in GetPropValueForModelField should be renamed to fieldName (this used to be used only for custom fields).

I think we probably should be handling the HeadWordRef for senses somewhere else.


Src/xWorks/ConfiguredLcmGenerator.cs line 705 at r1 (raw file):

Previously, mark-sil (Mark Kidder) wrote…

Instead of specifically checking for "HeadWordRef", is there something more general that I should be checking?

After much head scratching I don't think this is the correct solution. It seems that there should be a Sense method which uses the decorator to get the information...and it feels like it should already exist but it just isn't being used by this export yet.

@mark-sil mark-sil closed this Aug 13, 2025
@mark-sil mark-sil deleted the LT-22124 branch August 13, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants