LT-22124: Fix Sense homographs in Lexical Relations#437
Merged
Conversation
When getting a property value for a field on a ISenseOrEntry object, call the new method added to LCM that determines the specific object (Sense or Entry), and the specific field on that object, that should be queried to get the value. In this specific defect we are trying to get the HeadWordRef and the ISenseOrEntry is a LexSense. The specific field remains HeadWordRef, but the specific object we need to get the value from is the associated LexEntry. This is because the LexEntry adjusts the HeadWordRef based on the decorator, the LexSense does not. Change-Id: I51ee3b35d5b2482dda4a840e89700d14acda8994
jasonleenaylor
approved these changes
Aug 13, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting a property value for a field on a ISenseOrEntry object, call the new method added to LCM that determines the specific object (Sense or Entry), and the specific field on that object, that should be queried to get the value.
In this specific defect we are trying to get the HeadWordRef and the ISenseOrEntry is a LexSense. The specific field remains HeadWordRef, but the specific object we need to get the value from is the associated LexEntry. This is because the LexEntry adjusts the HeadWordRef based on the decorator, the LexSense does not.
This change is