WIP: Fix the extra span being generated (There may be a better fix)#453
Closed
jasonleenaylor wants to merge 1 commit into
Closed
WIP: Fix the extra span being generated (There may be a better fix)#453jasonleenaylor wants to merge 1 commit into
jasonleenaylor wants to merge 1 commit into
Conversation
|
commit 8301fa2f35: |
hahn-kev
reviewed
Sep 3, 2025
| propertyTable)); | ||
| selectors.AddRange(GenerateCssForWritingSystems(baseSelection + " span", configNode.Style, propertyTable)); | ||
| // add span for the writing system if we aren't already working on one | ||
| baseSelection = baseSelection.EndsWith(" span") ? baseSelection : baseSelection + " span"; |
There was a problem hiding this comment.
assuming this is a css selector could you do something like this?
baseSelection, baseSelection span {
styles...
}the comma here means OR. So if it already ends with span then you'll generate:
base span, base span span as the selector.
probably not what you want, but the only suggestion I can think of that might spark some other kind of idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is