Skip to content

Fix LT-22280: Yellow box when parsing a text#459

Merged
jtmaxwell3 merged 5 commits into
release/9.3from
LT-22280
Sep 12, 2025
Merged

Fix LT-22280: Yellow box when parsing a text#459
jtmaxwell3 merged 5 commits into
release/9.3from
LT-22280

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22280 by improving the error message so that the user can fix the problem the caused the yellow box error. It also clears the task report message when finished.


This change is Reviewable

@jtmaxwell3 jtmaxwell3 marked this pull request as draft September 10, 2025 22:39
@AndyBlack

Copy link
Copy Markdown
Collaborator

In XAmplePropertiesXAmpleDataFilesAugmenter.cs BuildAllomorphPropertyMapper(), consider changing
Dictionary<string, string> allomorphHvoPropertyMapper,
to be <string, List<string>> instead of <string, string>.
Then collect all the strings in the list for each hvo with a space between them and do the replace as
hvoMatch + " " + _those props_

@AndyBlack AndyBlack left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@jtmaxwell3 jtmaxwell3 marked this pull request as ready for review September 12, 2025 15:40
@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) September 12, 2025 15:42
@jtmaxwell3 jtmaxwell3 merged commit 59e5ad7 into release/9.3 Sep 12, 2025
4 of 5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22280 branch September 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants