Add S3 upload step to base installer workflow for automatic updates#462
Merged
jasonleenaylor merged 2 commits intoSep 16, 2025
Merged
Conversation
Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] using .github/workflows/patch-installer-cd.yml as an example add an s3 upload step to base-installer-cd.yml putting the offline and online installers in a jobs/FieldWorks-Win-all-Release-Base/${env.RELEASE_BASE_BUILD_NUMBER} location
Add S3 upload step to base installer workflow for automatic updates
Sep 16, 2025
Copilot stopped work on behalf of
jasonleenaylor due to an error
September 16, 2025 21:56
jasonleenaylor
approved these changes
Sep 16, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
jasonleenaylor
approved these changes
Sep 16, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @copilot)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds S3 upload functionality to the base installer continuous deployment workflow to support automatic updates in FieldWorks.
Problem
The base installer workflow (
base-installer-cd.yml) was missing the S3 upload step needed to make base installers available for automatic updates. The patch installer workflow already had this functionality, but base installers were not being uploaded to the expected S3 location that the automatic update system looks for.Solution
Added two new steps to the base installer workflow following the same pattern as the patch installer workflow:
Technical Details
s3://flex-updates/jobs/FieldWorks-Win-all-Release-Base/${RELEASE_BASE_BUILD_NUMBER}/FieldWorks_*_Online_x64.exeandFieldWorks_*_Offline_x64.exemake_release == 'true'(matching existing release logic)stage_installersstepThe S3 path structure matches exactly what the automatic update system expects based on the patterns defined in
Src/Common/FwUtils/FwUtilsTests/FwUpdaterTests.cs:Validation
This change enables the automatic update system to find and download base installers, completing the S3 upload coverage for both patch and base installers.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is