Fix patch installer workflow failure by providing default values for push events#469
Merged
jasonleenaylor merged 1 commit intoSep 22, 2025
Conversation
Copilot
AI
changed the title
Fix patch installer upload to s3
Fix patch installer workflow failure by providing default values for push events
Sep 20, 2025
Copilot stopped work on behalf of
jasonleenaylor due to an error
September 20, 2025 05:53
jasonleenaylor
approved these changes
Sep 20, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
This comment has been minimized.
This comment has been minimized.
dfa4b0e to
a343ceb
Compare
jasonleenaylor
approved these changes
Sep 22, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Patch Installer workflow (
patch-installer-cd.yml) was failing during push events because the "Upload Patch to S3" step was receiving empty values forBASE_RELEASEandBASE_BUILD_NUMBERenvironment variables.Problem
GitHub Actions
inputsare only available duringworkflow_dispatchevents. When the workflow is triggered by push events, expressions like${{ inputs.base_release }}evaluate to empty strings rather than their defined default values, causing this error:Solution
Modified the environment variable declarations to use GitHub Actions' fallback syntax:
This ensures that:
workflow_dispatchevents: Uses the provided input valuespushevents: Uses the default value'build-1141'forBASE_RELEASEImpact
The workflow now works correctly for both manual triggers and automatic push events. Patch installers will be properly uploaded to S3 with the correct naming pattern expected by the FwUpdater.cs automatic update system:
jobs/FieldWorks-Win-all-Release-Patch/[build-number]/FieldWorks_[version]_b[base-build]_x64.mspThis is a minimal, surgical fix that changes only 2 lines to resolve the workflow failure while maintaining backward compatibility with manual workflow dispatches.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
This change is