Skip to content

Fix patch installer workflow failure by providing default values for push events#469

Merged
jasonleenaylor merged 1 commit into
release/9.3from
copilot/fix-407956c9-6d85-45bf-9d1f-3060644107c9
Sep 22, 2025
Merged

Fix patch installer workflow failure by providing default values for push events#469
jasonleenaylor merged 1 commit into
release/9.3from
copilot/fix-407956c9-6d85-45bf-9d1f-3060644107c9

Conversation

Copilot AI commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

The Patch Installer workflow (patch-installer-cd.yml) was failing during push events because the "Upload Patch to S3" step was receiving empty values for BASE_RELEASE and BASE_BUILD_NUMBER environment variables.

Problem

GitHub Actions inputs are only available during workflow_dispatch events. When the workflow is triggered by push events, expressions like ${{ inputs.base_release }} evaluate to empty strings rather than their defined default values, causing this error:

Must have a base_build_number nor a valid base_release to support automatic updating

Solution

Modified the environment variable declarations to use GitHub Actions' fallback syntax:

env:
  BASE_RELEASE: ${{ inputs.base_release || 'build-1141' }}
  BASE_BUILD_NUMBER: ${{ inputs.base_build_number || '' }}

This ensures that:

  • During workflow_dispatch events: Uses the provided input values
  • During push events: Uses the default value 'build-1141' for BASE_RELEASE

Impact

The workflow now works correctly for both manual triggers and automatic push events. Patch installers will be properly uploaded to S3 with the correct naming pattern expected by the FwUpdater.cs automatic update system:

jobs/FieldWorks-Win-all-Release-Patch/[build-number]/FieldWorks_[version]_b[base-build]_x64.msp

This is a minimal, surgical fix that changes only 2 lines to resolve the workflow failure while maintaining backward compatibility with manual workflow dispatches.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.


This change is Reviewable

@jasonleenaylor jasonleenaylor changed the title [WIP] The Patch Installer (patch-installer-cd.yml) failed after my latest update because the Upload Patch to s3 steps thinks the base_release was not set. Find the source of the failure and propose a fix Fix patch installer upload to s3 Sep 20, 2025
Copilot AI changed the title Fix patch installer upload to s3 Fix patch installer workflow failure by providing default values for push events Sep 20, 2025

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @copilot)

@jasonleenaylor jasonleenaylor marked this pull request as ready for review September 20, 2025 05:57
@jasonleenaylor jasonleenaylor enabled auto-merge (squash) September 20, 2025 05:57
@github-actions

This comment has been minimized.

@jasonleenaylor jasonleenaylor force-pushed the copilot/fix-407956c9-6d85-45bf-9d1f-3060644107c9 branch from dfa4b0e to a343ceb Compare September 22, 2025 15:09

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @copilot)

@jasonleenaylor jasonleenaylor merged commit c78d2a4 into release/9.3 Sep 22, 2025
4 checks passed
@jasonleenaylor jasonleenaylor deleted the copilot/fix-407956c9-6d85-45bf-9d1f-3060644107c9 branch September 22, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants