Fix the assembly stamping of the base build after moving to gha#478
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build system to work with GitHub Actions (GHA) by replacing Jenkins-specific environment variable references with GHA equivalents for assembly stamping.
- Updates environment variable names from Jenkins conventions to GitHub Actions conventions
- Changes
BUILD_NUMBERtoRELEASE_BASE_BUILD_NUMBERfor build numbering - Replaces
BaseBuildishwithBASE_BUILD_NUMBERfor patch build detection
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jasonleenaylor
force-pushed
the
fix/patching
branch
from
9a7a875 to
6631cdf
Compare
KenZook
reviewed
Sep 29, 2025
KenZook
left a comment
KenZook
left a comment
Contributor
There was a problem hiding this comment.
@KenZook reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @jasonleenaylor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is