LT-22182 Add "Find" to sketch and Try a Word#480
Merged
Conversation
Change-Id: I3daa53c57e08fc018b6334760dd3e9d057309726
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, all discussions resolved
Src/Transforms/Presentation/FormatXAmpleTrace.xsl line 387 at r1 (raw file):
--> <xsl:template name="Script"> <script language="JavaScript" id="clientEventHandlersJS">
Nice refactor!
Src/LexText/ParserUI/TryAWordDlg.cs line 377 at r1 (raw file):
findDialog.Show(this); } else if (e.KeyCode == 27)
There is an enum we should use here for readability. Keys.Escape I think.
Code quote:
27Change-Id: Ia64bc9f3b01a596b2cdc346060a52a9c443f8fc0
Collaborator
Author
|
Thank you, Jason. |
jasonleenaylor
approved these changes
Oct 1, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Find dialog to the grammar sketch and to the various outputs of Try a Word.
This adds javascript (and a little CSS) to each web page produced by the various transforms used. The javascript and CSS code are in the new JSFunctions.xsl file.
The Find dialog is launched whenever the use keys CTL-F or right-clicks and chooses the one Find option. It allows the user to match by case and shows the number of matches. The current match is highlighted in orange; all other matches ae highlighted in yellow. It tries to center the current match in the window. It automatically wraps when the last/fist item is found and the user asks to find the next/previous match.
This change is