Include all frameworks in local LCM, Palaso & Chorus#481
Merged
Conversation
One of the LCM target frameworks is netstandard2.0. To build a local LCM that uses a local Palaso, LCM needs the netstandard2.0 framework to be in the palaso nupkg. By removing the TargetFrameworks parameter from the ‘dotnet pack’ command the nuget packages will contain all the frameworks specified in the .csproj files. Change-Id: Ia31076ec00105f880b88c975a8eee37dfa63d8b9
jasonleenaylor
approved these changes
Oct 2, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
So, when I originally wrote these it was necessary to pack only the target version (possibly because most developer machines didn't yet have the dotnet core workload installed) If this works now then -
If it doesn't work for someone we just need to add some sort of test and error condition to guide developers to what the requirements are to run this.
@jasonleenaylor reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the LCM target frameworks is netstandard2.0. To build a local LCM that uses a local Palaso, LCM needs the netstandard2.0 framework to be in the palaso nupkg. By removing the TargetFrameworks parameter from the ‘dotnet pack’ command the nuget packages will contain all the frameworks specified in the .csproj files.
Change-Id: Ia31076ec00105f880b88c975a8eee37dfa63d8b9
This change is